858820 - Clean upsell on deleting

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Matt Basta [:basta]]

https://marketplace-dev.allizom.org/api/v1/apps/search/?q=

The above URL throws a 500.

Comment 1

[Andy McKay]

Sure its a 500? There's no error.

receipts $ curl -i https://marketplace-dev.allizom.org/api/v1/apps/search/?q=
HTTP/1.1 404 NOT FOUND
X-API-Version: 1
Server: gunicorn/0.15.0
Vary: X-Requested-With, Accept-Language, Cookie, X-Mobile, User-Agent
Content-Type: application/json; charset=utf-8
Strict-Transport-Security: max-age=2592000
Date: Fri, 05 Apr 2013 22:44:40 GMT
Transfer-Encoding: chunked
Access-Control-Allow-Origin: *
X-Content-Security-Policy-Report-Only: policy-uri /services/csp/policy?build=5b5b
Via: Moz-pp-zlb09
Connection: keep-alive
Set-Cookie: lang="en-US\054"; Path=/
Set-Cookie: region=us; Path=/
Access-Control-Allow-Methods: GET, OPTIONS

{"error_message": "Sorry, this request could not be processed. Please try again later."}

Comment 2

[Matt Basta [:basta]]

I call it a 500 because the "Sorry this request ..." message is the Django 500 message. 404 is just as well.

Comment 3

[Andy McKay]

Re-indexing ES. It's stopped throwing 404's and is now throwing 200's but no results. Let's see how that goes.

Comment 4

[Andy McKay]

An addon being used in the results has an upsell. The upsell was deleted but the table never cleaned up.

Comment 5

[Andy McKay]

https://github.com/andymckay/zamboni/commit/10afad

Comment 6

[Andy McKay]

Was a bit more than one point btw.