Closed Bug 858954 Opened 11 years ago Closed 11 years ago

Intermittent test-page-mod.test page-mod on private tab | Test output exceeded timeout (60s). after TypeError: tab is null

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: evold)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Pull request 939
165 bytes, text/html
evold
: review+
Details
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/962
355 bytes, text/html
mossop
: review+
Details 
https://tbpl.mozilla.org/php/getParsedLog.php?id=21502541&tree=Profiling
Rev3 WINNT 5.1 profiling opt test jetpack on 2013-04-05 16:59:49 PDT for push 367be8497f7e
slave: talos-r3-xp-009

TEST-START | tests/test-page-mod.test page-mod on private tab
TEST-INFO | [JavaScript Error: "TypeError: aWindow.document.documentElement is null" {file: "resource:///modules/sessionstore/SessionStore.jsm" line: 675}]
error: addon-sdk: An exception occurred.
TypeError: tab is null
resource://gre/modules/commonjs/sdk/tabs/utils.js 266
Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/lang/functional.js", line 54, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://gre/modules/commonjs/sdk/tabs/utils.js", line 266, in setTabURL
    if (tab.browser)
TEST-INFO | [JavaScript Error: "TypeError: tab is null" {file: "resource://gre/modules/XPIProvider.jsm -> jar:file:///c:/docume~1/cltbld/locals~1/temp/tmp0sshzu.mozrunner/extensions/4786a5a4-b6a5-45fc-9041-1256ca069d29@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/utils.js" line: 163}]
TEST-INFO | [JavaScript Error: "addon-sdk: An exception occurred.
TypeError: tab is null
resource://gre/modules/commonjs/sdk/tabs/utils.js 266
Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/lang/functional.js", line 54, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://gre/modules/commonjs/sdk/tabs/utils.js", line 266, in setTabURL
    if (tab.browser)
"]
TEST-UNEXPECTED-FAIL | tests/test-page-mod.test page-mod on private tab | Test output exceeded timeout (60s).
Traceback (most recent call last):
  File "jetpack/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "c:\talos-slave\test\build\jetpack\python-lib\cuddlefish\__init__.py", line 602, in run
    test_all_packages(env_root, defaults=options.__dict__)
  File "c:\talos-slave\test\build\jetpack\python-lib\cuddlefish\__init__.py", line 484, in test_all_packages
    env_root=env_root)
  File "c:\talos-slave\test\build\jetpack\python-lib\cuddlefish\__init__.py", line 928, in run
    bundle_sdk=options.bundle_sdk)
  File "c:\talos-slave\test\build\jetpack\python-lib\cuddlefish\runner.py", line 743, in run_app
    OUTPUT_TIMEOUT, test_name, parseable)
Exception: Test output exceeded timeout (60s).
Alex could you please take a look at this one ?
Assignee: nobody → poirot.alex
Attached file Pull request 939 — 
The main issue is that exception "TypeError: tab is null", that happens when we call setTabURL(rawTab, ...). Because rawTab returned by getActiveTab(win) is null.
It means that either win.gBrowser isn't set yet (seems unlikely) or gBrowser.selectedTab is null. That might be that second option, as gBrowser.init is called on load, so it can be called after our code that is also waiting for load event.

In this patch, I'm waiting for delayed startup in order to ensure that everything is fully set.
Attachment #737464 - Flags: review?(evold)
Comment on attachment 737464 [details]
Pull request 939

just one nit
Attachment #737464 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ba587daf24476e5c7f7d58a3208d348214a57628
Bug 858954 - Wait for delayed startup before touching browser window.

https://github.com/mozilla/addon-sdk/commit/944219c3e1e531db5c8a6585fbcaec7b405829e6
Merge pull request #939 from ochameau/bug858954

Bug 858954 - Wait for delayed startup before touching browser window. r=@erikvold
Seems to be no more "tab is null," but instead "TEST-INFO | [JavaScript Error: "TypeError: aWindow.document.documentElement is null" {file: "resource:///modules/sessionstore/SessionStore.jsm" line: 675}]"
Ah I bet this bug is happening because of bug 855866..
Depends on: 855866
Attachment #740696 - Flags: review?(dtownsend+bugmail)
Assignee: poirot.alex → evold
OS: Windows XP → All
Hardware: x86 → All
Attachment #740696 - Flags: review?(dtownsend+bugmail) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/71bf063c6dbba5116f35bdbfecda9bf2bb388572
Bug 858954: using a different method to open windows in a pb related helper

https://github.com/mozilla/addon-sdk/commit/0f451f6d0dad0a01a42ffad76f77ac0cad76946e
Merge pull request #962 from erikvold/858954

Fix Bug 858954: using a different method to open windows in a pb related helper r=@Mossop
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: