858975 - Shortcut key for Inspector is conflicting with shortcut key for undo close tab

Status: RESOLVED FIXED

(Mozilla Localizations :: hu / Hungarian, defect)

Description

[Zulkarnain K. [:LouCypher]]

UA: Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20100101 Firefox/20.0

Steps to reproduce:
1. Run Firefox/hu on a clean profile
2. Press Ctrl+Shift+T

   Expected result:
   Inspector panel is open

   Actual result:
   Nothing happened

3. Open a web page in a tab
4. Close the tab
5. Repeat step 2
6. The previously closed tab is open

Comment 1

[Gergely]

The same bug irritated me. For now, I've edited inspector.properties in the omni.ja zip file:
-inspector.commandkey=T
-inspector.accesskey=T
+inspector.commandkey=I
+inspector.accesskey=I

Comment 2

[Kami]

Fix committed to BAC
committed changeset:
949:f1462ce46036
475:3c85f1e750a2
224:5bc3905f84e6

Thank you for the report and the possible solution.

Comment 4

[Gergely]

(In reply to Kami from comment #2)

Fixed in what version of Firefox? This bug came back on me with Firefox 21.0. :(

Comment 5

[avada]

(In reply to Gergely from comment #4)
> (In reply to Kami from comment #2)
> 
> Fixed in what version of Firefox? This bug came back on me with Firefox
> 21.0. :(

Ouch. Also the debugger's ctrl+shift+j is the same as the error console's.

Comment 6

[Kami]

(In reply to Gergely from comment #4)
> (In reply to Kami from comment #2)
> 
> Fixed in what version of Firefox? This bug came back on me with Firefox
> 21.0. :(

Currently looks okay in Beta, Aurora and Central:

inspector.commandkey=I
inspector.accesskey=V

Comment 7

[Gergely]

Somehow a bug with the same effect is introduced in version 25, but inspector.properties seems OK. Now both C-S-t and C-S-t open Inspector. :(

Comment 8

[Gergely]

I meant C-S-t and C-S-i.

Comment 9

[avada]

I think I experienced something like this with ff24. I don't remember the hotkey though. I just overrode it the keyconfig extension.

Comment 10

[Kami]

Ok, I sent a patch to beta, aurora and central.
https://hg.mozilla.org/releases/l10n/mozilla-aurora/hu/rev/45f95957f56b
https://hg.mozilla.org/releases/l10n/mozilla-beta/hu/rev/3ffba337dd1a

Gábor can you check it?

Pike, is there any way to create a new release for Hungarian version that fix this problem?

Comment 11

[Axel Hecht [:Pike]]

Sorry, but we're not taking l10n updates on the release channel out of band.

Comment 12

[upo001]

Still buggy in 25.0, now Toggle tools (Eszközök be/ki) is Ctrl-Shift-T and it conflicts with undo close tab.
http://kepfeltoltes.hu/131101/ctrl-shift-t_www.kepfeltoltes.hu_.png

Comment 13

[libertiny.g+firefox]

(In reply to Gergely from comment #4)
> (In reply to Kami from comment #2)
> 
> Fixed in what version of Firefox? This bug came back on me with Firefox
> 21.0. :(

@Gergely: Could you write a short description, how to modify the omni.ja until the official bug fix?

Comment 14

[Gergely]

> @Gergely: Could you write a short description, how to modify the omni.ja
> until the official bug fix?

It's a zip file, so you can use whatever zip manager you like. I used Total Commander last time, but I don't have write access for the main Firefox directory now, so I can't fix it. :( A workaround, anyone (besides portable Firefox)?
You can see what you should modify at https://hg.mozilla.org/releases/l10n/mozilla-beta/hu/rev/3ffba337dd1a

Comment 15

[libertiny.g+firefox]

(In reply to Gergely from comment #14)
> > @Gergely: Could you write a short description, how to modify the omni.ja
> > until the official bug fix?
> 
> It's a zip file, so you can use whatever zip manager you like. I used Total
> Commander last time, but I don't have write access for the main Firefox
> directory now, so I can't fix it. :( A workaround, anyone (besides portable
> Firefox)?
> You can see what you should modify at
> https://hg.mozilla.org/releases/l10n/mozilla-beta/hu/rev/3ffba337dd1a

With a bit more google-fu I found this thread, and now it works like charm.
Köszi

However, the issue is still unresolved, so the Status is invalid.

Comment 16

[Kami]

The fix is comitted to Beta, Aurora and Central. There is no chance to provide updated release for Firefox 25. Possible workarounds:
1) Switch to Beta (works)
2) Create and make available custom language pack with the fix (need to do)
3) Do it by hand (need an article)

Comment 17

[Zulkarnain K. [:LouCypher]]

Other workaround is to download the langpack at
http://download.cdn.mozilla.net/pub/mozilla.org/firefox/releases/latest/win32/xpi/hu.xpi
(because it's not available on https://addons.mozilla.org/firefox/language-tools/)

1. Modify browser.dtd inside the package
   (see https://hg.mozilla.org/releases/l10n/mozilla-beta/hu/rev/3ffba337dd1a)
2. Install the langpack
3. Restart Firefox or open a new window to see the changes

Comment 18

[libertiny.g+firefox]

Thanks guys!

Comment 19

[Gergely]

25.0.1 did it again. Drat!

Comment 20

[Zulkarnain K. [:LouCypher]]

(In reply to Gergely from comment #19)
> 25.0.1 did it again. Drat!

It won't be fixed until major release (v26.0).