859012 - Pressing ESC when a panel is open should hide the panel

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

With this panel:

let previewPanel = Panel({
  width: 1200,
  height: 400
});

pressing ESC hides the panel, but with this panel:

let previewPanel = Panel({
  width: 1200,
  height: 400,
  focus: false
});

Pressing ESC will hide the panel then show it again immediately.  Pressing ESC for this panel should simply hide it.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Currently working, Erik, can you provide how you're toggling/using these panels to cause this issue?

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Still an issue: "it's still an issue, try my page-portals add-on and log in to github with a portal" - Erik

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Alright, cfx run https://github.com/erikvold/ubilite-jetpack, and type `google test` in the url bar, then press `esc`

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

I suspect this is due to bug 888688, but we should at least get a test in before closing this bug.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Alright I think this is working now.