Pressing ESC when a panel is open should hide the panel

RESOLVED INVALID

Status

Add-on SDK
General
P2
normal
RESOLVED INVALID
5 years ago
4 years ago

People

(Reporter: erikvold, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

With this panel:

let previewPanel = Panel({
  width: 1200,
  height: 400
});

pressing ESC hides the panel, but with this panel:

let previewPanel = Panel({
  width: 1200,
  height: 400,
  focus: false
});

Pressing ESC will hide the panel then show it again immediately.  Pressing ESC for this panel should simply hide it.
Blocks: 821476

Updated

5 years ago
Priority: -- → P2
Assignee: nobody → jsantell
Currently working, Erik, can you provide how you're toggling/using these panels to cause this issue?
Flags: needinfo?(evold)
Blocks: 879068
Still an issue: "it's still an issue, try my page-portals add-on and log in to github with a portal" - Erik
Flags: needinfo?(evold)
Alright, cfx run https://github.com/erikvold/ubilite-jetpack, and type `google test` in the url bar, then press `esc`
I suspect this is due to bug 888688, but we should at least get a test in before closing this bug.
Depends on: 888688
Assignee: jsantell → nobody
Alright I think this is working now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.