Closed Bug 859018 Opened 7 years ago Closed 6 years ago

Remove the MSVC exemption for FAIL_ON_WARNINGS in layout

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
All
Windows 8
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file, 1 obsolete file)

patch
20.90 KB, patch
dbaron
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
No description provided.
Attachment #734321 - Flags: review?(dbaron)
Attached patch patch — — Splinter Review 
Rebased to tip
Attachment #734321 - Attachment is obsolete: true
Attachment #734321 - Flags: review?(dbaron)
Attachment #740008 - Flags: review?(dbaron)
Comment on attachment 740008 [details] [diff] [review]
patch

Please use the suffixes (and, when needed "0.0f" rather than "0") consistently in:
  nsGfxScrollFrameInner::ScrollBy
  nsMathMLmoFrame::ProcessOperatorData
  nsTimingFunction::AssignFromKeyword
  nsTableFrame::ReflowChildren
rather than in only some places.

Please use float(M_SQRT2) instead of static_cast<float>(M_SQRT2) in nsMathMLChar::StretchInternal.

r=dbaron with that
Attachment #740008 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/70ada7d7a92e
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/70ada7d7a92e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.