Closed Bug 859022 Opened 7 years ago Closed 7 years ago
Remove the MSVC exemption for FAIL
_ON _WARNINGS in content/media
No description provided.
What is base/compiler_specific? Shouldn't this stuff be in an MFBT header file?
Rebased to tip
What about comment #1?
Comment on attachment 740010 [details] [diff] [review] patch Canceling the review request until bug 839998 is resolved.
Using MOZ_THIS_IN_INITIALIZER_LIST macro introduced by bug 839998.
Attachment #767785 - Flags: review?(roc)
Attachment #767785 - Flags: review?(roc) → review+
Status: NEW → ASSIGNED
Assignee: nobody → VYV03354
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment on attachment 767785 [details] [diff] [review] patch I'd like to take this patch on Aurora in order to reduce the differences between the Web Audio implementation on trunk and Aurora. This shouldn't have any runtime effects, and just fixes a bunch of compiler warnings on Windows. No strings or uuid changes.
Attachment #767785 - Flags: approval-mozilla-aurora?
Comment on attachment 767785 [details] [diff] [review] patch Approving, assuming the patch is low risk based on the approval-nomination comment.
Attachment #767785 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out because of build bustage: https://hg.mozilla.org/releases/mozilla-aurora/rev/554a3d3aeefe Masatoshi, does this rely on bug 839998 to build?
Yes, as the "Depends on" field indicates.
You need to log in before you can comment on or make changes to this bug.