Closed Bug 859022 Opened 7 years ago Closed 7 years ago

Remove the MSVC exemption for FAIL_ON_WARNINGS in content/media

Categories

(Core :: Audio/Video, defect)

All
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25
Tracking Status
firefox24 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #734325 - Flags: review?(roc)
What is base/compiler_specific? Shouldn't this stuff be in an MFBT header file?
Depends on: 839998
Attached patch patchSplinter Review
Rebased to tip
Attachment #734325 - Attachment is obsolete: true
Attachment #734325 - Flags: review?(roc)
Attachment #740010 - Flags: review?(roc)
Comment on attachment 740010 [details] [diff] [review]
patch

Canceling the review request until bug 839998 is resolved.
Attachment #740010 - Flags: review?(roc)
Attached patch patchSplinter Review
Using MOZ_THIS_IN_INITIALIZER_LIST macro introduced by bug 839998.
Attachment #767785 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/aeae60c65cc7
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/aeae60c65cc7
Assignee: nobody → VYV03354
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment on attachment 767785 [details] [diff] [review]
patch

I'd like to take this patch on Aurora in order to reduce the differences between the Web Audio implementation on trunk and Aurora.  This shouldn't have any runtime effects, and just fixes a bunch of compiler warnings on Windows.  No strings or uuid changes.
Attachment #767785 - Flags: approval-mozilla-aurora?
Comment on attachment 767785 [details] [diff] [review]
patch

Approving, assuming the patch is low risk based on the approval-nomination comment.
Attachment #767785 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out because of build bustage: https://hg.mozilla.org/releases/mozilla-aurora/rev/554a3d3aeefe

Masatoshi, does this rely on bug 839998 to build?
Flags: needinfo?(VYV03354)
Yes, as the "Depends on" field indicates.
Flags: needinfo?(VYV03354)
You need to log in before you can comment on or make changes to this bug.