859062 - Hide right arrow in the SideMenuWidget

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

The right arrow is shown when the network details pane isn't open and I feel like this is pretty ugly.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

I also flattened the DOM a bit hopefully making the whole thing faster in the netmonitor case.

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 735096 [details] [diff] [review]
v1

Review of attachment 735096 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +456,5 @@
>      let name = NetworkHelper.convertToUnicode(unescape(uri.fileName)) || "/";
>      let query = NetworkHelper.convertToUnicode(unescape(uri.query));
>      let hostPort = NetworkHelper.convertToUnicode(unescape(uri.hostPort));
>  
> +    let template = $("#requests-menu-item-template").cloneNode(true);

There shouldn't be a .cloneNode() here.

Comment 4

[Dave Camp (:dcamp)]

Comment on attachment 735096 [details] [diff] [review]
v1

Review of attachment 735096 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/SideMenuWidget.jsm
@@ +38,2 @@
>   */
> +this.SideMenuWidget = function SideMenuWidget(aNode, aShowArrows = true) {

Do you think this should be a boolean?  Do you expect this to be the last configuration ever?  Maybe an options object?

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Dave Camp (:dcamp) from comment #4)
> 
> Do you think this should be a boolean?  Do you expect this to be the last
> configuration ever?  Maybe an options object?

I.. don't care that much for now.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/9c4a7e02a3d6

Comment 7

[Victor Porof [:vporof][:vp]]

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c4a7e02a3d6