Closed Bug 859062 Opened 7 years ago Closed 7 years ago

Hide right arrow in the SideMenuWidget

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(2 files)

Attached image screenshot
The right arrow is shown when the network details pane isn't open and I feel like this is pretty ugly.
Duplicate of this bug: 859407
Attached patch v1Splinter Review
I also flattened the DOM a bit hopefully making the whole thing faster in the netmonitor case.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #735096 - Flags: review?(dcamp)
Comment on attachment 735096 [details] [diff] [review]
v1

Review of attachment 735096 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +456,5 @@
>      let name = NetworkHelper.convertToUnicode(unescape(uri.fileName)) || "/";
>      let query = NetworkHelper.convertToUnicode(unescape(uri.query));
>      let hostPort = NetworkHelper.convertToUnicode(unescape(uri.hostPort));
>  
> +    let template = $("#requests-menu-item-template").cloneNode(true);

There shouldn't be a .cloneNode() here.
Priority: -- → P3
Comment on attachment 735096 [details] [diff] [review]
v1

Review of attachment 735096 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/SideMenuWidget.jsm
@@ +38,2 @@
>   */
> +this.SideMenuWidget = function SideMenuWidget(aNode, aShowArrows = true) {

Do you think this should be a boolean?  Do you expect this to be the last configuration ever?  Maybe an options object?
Attachment #735096 - Flags: review?(dcamp) → review+
(In reply to Dave Camp (:dcamp) from comment #4)
> 
> Do you think this should be a boolean?  Do you expect this to be the last
> configuration ever?  Maybe an options object?

I.. don't care that much for now.
Whiteboard: [fixed-in-fx-team]
Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.
Component: Developer Tools → Developer Tools: Netmonitor
Summary: [netmonitor] Hide right arrow in the SideMenuWidget → Hide right arrow in the SideMenuWidget
https://hg.mozilla.org/mozilla-central/rev/9c4a7e02a3d6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.