Closed Bug 859066 Opened 11 years ago Closed 11 years ago

Fixing warning in nsprpub/pr/src/misc/prnetdb.c

Categories

(NSPR :: NSPR, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bgdn.ciobanu, Assigned: wtc)

Details

Attachments

(1 file, 2 obsolete files)

/home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c: In function ‘pr_NetAddrToStringGNI’:
 1:19.92 Warning: -Wunused-but-set-variable in /home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c: variable ‘md_af’ set but not used
 1:19.92 /home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c:2255:14: warning: variable ‘md_af’ set but not used [-Wunused-but-set-variable]

I will send a patch soon.
Attached patch fix the warning (obsolete) — Splinter Review
Attachment #734348 - Flags: review?(wtc)
Attached patch fix the warning (obsolete) — Splinter Review
Attachment #734348 - Attachment is obsolete: true
Attachment #734348 - Flags: review?(wtc)
Attachment #734351 - Flags: review?
Attachment #734351 - Flags: review? → review?(wtc)
(In reply to bgdn.ciobanu from comment #2)
> Created attachment 734351 [details] [diff] [review]
> fix the warning

I'm assuming you forgot to mark someone in particular for review, hence why I reflagged wtc. Sorry if this wasn't what you wanted!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Bogdan: thank you for the bug report and the patch. Your patch
will break the compilation on some platforms. Could you please
test this patch?

Kai: it should be easy to see that this patch won't break things.
You just need to verify that. You don't need to verify that this
patch fixes the "variable set but not used" warning.
Attachment #734351 - Attachment is obsolete: true
Attachment #734351 - Flags: review?(wtc)
Attachment #745255 - Flags: review?(kaie)
Attachment #745255 - Flags: feedback?(bgdn.ciobanu)
Comment on attachment 745255 [details] [diff] [review]
fix the warning, v2

r=kaie
Attachment #745255 - Flags: review?(kaie) → review+
Comment on attachment 745255 [details] [diff] [review]
fix the warning, v2

I reproduced the warning on Linux x86_64 and verified the patch
fixed the warning.

https://hg.mozilla.org/projects/nspr/rev/ff10dbda9cc8
Attachment #745255 - Flags: feedback?(bgdn.ciobanu) → checked-in+
Status: NEW → RESOLVED
Closed: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → 4.10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: