Closed
Bug 859066
Opened 11 years ago
Closed 11 years ago
Fixing warning in nsprpub/pr/src/misc/prnetdb.c
Categories
(NSPR :: NSPR, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
4.10
People
(Reporter: bgdn.ciobanu, Assigned: wtc)
Details
Attachments
(1 file, 2 obsolete files)
616 bytes,
patch
|
KaiE
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
/home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c: In function ‘pr_NetAddrToStringGNI’: 1:19.92 Warning: -Wunused-but-set-variable in /home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c: variable ‘md_af’ set but not used 1:19.92 /home/bogdan/work/mozilla/mozilla-central/nsprpub/pr/src/misc/prnetdb.c:2255:14: warning: variable ‘md_af’ set but not used [-Wunused-but-set-variable] I will send a patch soon.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #734348 -
Flags: review?(wtc)
Reporter | ||
Comment 2•11 years ago
|
||
Attachment #734348 -
Attachment is obsolete: true
Attachment #734348 -
Flags: review?(wtc)
Attachment #734351 -
Flags: review?
Updated•11 years ago
|
Attachment #734351 -
Flags: review? → review?(wtc)
Comment 3•11 years ago
|
||
(In reply to bgdn.ciobanu from comment #2) > Created attachment 734351 [details] [diff] [review] > fix the warning I'm assuming you forgot to mark someone in particular for review, hence why I reflagged wtc. Sorry if this wasn't what you wanted!
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 4•11 years ago
|
||
Bogdan: thank you for the bug report and the patch. Your patch will break the compilation on some platforms. Could you please test this patch? Kai: it should be easy to see that this patch won't break things. You just need to verify that. You don't need to verify that this patch fixes the "variable set but not used" warning.
Attachment #734351 -
Attachment is obsolete: true
Attachment #734351 -
Flags: review?(wtc)
Attachment #745255 -
Flags: review?(kaie)
Attachment #745255 -
Flags: feedback?(bgdn.ciobanu)
Comment 5•11 years ago
|
||
Comment on attachment 745255 [details] [diff] [review] fix the warning, v2 r=kaie
Attachment #745255 -
Flags: review?(kaie) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 745255 [details] [diff] [review] fix the warning, v2 I reproduced the warning on Linux x86_64 and verified the patch fixed the warning. https://hg.mozilla.org/projects/nspr/rev/ff10dbda9cc8
Attachment #745255 -
Flags: feedback?(bgdn.ciobanu) → checked-in+
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → 4.10
You need to log in
before you can comment on or make changes to this bug.
Description
•