859100 - java.lang.NullPointerException: at org.mozilla.gecko.BrowserToolbar.canToolbarHide(BrowserToolbar.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 22.0a2/20130407: bp-c0bf3acd-9c3e-4ab9-b54e-050c92130407.

java.lang.NullPointerException
	at org.mozilla.gecko.BrowserToolbar.canToolbarHide(BrowserToolbar.java:500)
	at org.mozilla.gecko.BrowserToolbar.animateVisibility(BrowserToolbar.java:522)
	at org.mozilla.gecko.BrowserToolbar.animateVisibilityWithVelocityBias(BrowserToolbar.java:546)
	at org.mozilla.gecko.BrowserApp.onInterceptTouchEvent(BrowserApp.java:335)
	at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:149)
	at android.view.View.dispatchTouchEvent(View.java:5579)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1959)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1720)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1982)
	at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1441)
	at android.app.Activity.dispatchTouchEvent(Activity.java:2421)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1930)
	at android.view.View.dispatchPointerEvent(View.java:5759)
	at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:2970)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2529)
	at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:869)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2538)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:4945)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.BrowserToolbar.canToolbarHide%28BrowserToolbar.java%29

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix possible NPE in BrowserToolbar.canToolbarHide

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 735764 [details] [diff] [review]
Fix possible NPE in BrowserToolbar.canToolbarHide

Review of attachment 735764 [details] [diff] [review]:
-----------------------------------------------------------------

You can also use layerView.getViewportMetrics() directly.

Comment 3

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/03f97f46000d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03f97f46000d

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Chris, Should we push the patch to Aurora?  If so could you nom it please?

Comment 6

[Scoobidiver (away)]

I am not Chris.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Sorry. wrong drop down was selected at the time; meant assignee not reporter.

Comment 8

[Chris Lord [:cwiiis]]

This shouldn't be necessary now that the dynamic toolbar is disabled.