Closed Bug 859100 Opened 8 years ago Closed 8 years ago

java.lang.NullPointerException: at org.mozilla.gecko.BrowserToolbar.canToolbarHide(BrowserToolbar.java)

Categories

(Firefox for Android Graveyard :: General, defect)

22 Branch
ARM
Android
defect
Not set
critical

Tracking

(firefox22 disabled)

RESOLVED FIXED
Firefox 23
Tracking Status
firefox22 --- disabled

People

(Reporter: scoobidiver, Assigned: cwiiis)

References

Details

(Keywords: crash, regression, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file)

There's one crash in 22.0a2/20130407: bp-c0bf3acd-9c3e-4ab9-b54e-050c92130407.

java.lang.NullPointerException
	at org.mozilla.gecko.BrowserToolbar.canToolbarHide(BrowserToolbar.java:500)
	at org.mozilla.gecko.BrowserToolbar.animateVisibility(BrowserToolbar.java:522)
	at org.mozilla.gecko.BrowserToolbar.animateVisibilityWithVelocityBias(BrowserToolbar.java:546)
	at org.mozilla.gecko.BrowserApp.onInterceptTouchEvent(BrowserApp.java:335)
	at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:149)
	at android.view.View.dispatchTouchEvent(View.java:5579)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1959)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1720)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1965)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1734)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1982)
	at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1441)
	at android.app.Activity.dispatchTouchEvent(Activity.java:2421)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1930)
	at android.view.View.dispatchPointerEvent(View.java:5759)
	at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:2970)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2529)
	at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:869)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2538)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:4945)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.BrowserToolbar.canToolbarHide%28BrowserToolbar.java%29
Keywords: regression
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Attachment #735764 - Flags: review?(bugmail.mozilla)
Comment on attachment 735764 [details] [diff] [review]
Fix possible NPE in BrowserToolbar.canToolbarHide

Review of attachment 735764 [details] [diff] [review]:
-----------------------------------------------------------------

You can also use layerView.getViewportMetrics() directly.
Attachment #735764 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/03f97f46000d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Chris, Should we push the patch to Aurora?  If so could you nom it please?
Flags: needinfo?(scoobidiver)
I am not Chris.
Flags: needinfo?(scoobidiver) → needinfo?(chrislord.net)
Sorry. wrong drop down was selected at the time; meant assignee not reporter.
This shouldn't be necessary now that the dynamic toolbar is disabled.
Flags: needinfo?(chrislord.net)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.