ifdef DEBUG unused in imgRequest.cpp

RESOLVED FIXED in mozilla23

Status

()

Core
ImageLib
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luisbg, Assigned: luisbg)

Tracking

Trunk
mozilla23
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130311191316

Steps to reproduce:

There is an unused ifdef DEBUG, only containing a comment, around line 670 of imgRequest.cpp

#ifdef DEBUG
    /* NS_WARNING if the content type from the channel isn't the same if the sniffing */
#endif
(Assignee)

Comment 1

5 years ago
Created attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG
(Assignee)

Comment 2

5 years ago
In a related note concerning the same file. Should the line that says:
#ifdef DEBUG_joe

should be?
#ifdef DEBUG
(Assignee)

Updated

5 years ago
Attachment #734416 - Flags: review?
Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

You should request a review from a person or you patch might be lost
Attachment #734416 - Flags: review? → review?(jmuizelaar)
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

5 years ago
Attachment #734416 - Flags: review?(mbrubeck)
Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

I'll leave this to jmuizelaar to review.
Attachment #734416 - Flags: review?(mbrubeck)
(Assignee)

Updated

5 years ago
Assignee: nobody → luis
Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't write the comment. So I'm not sure if it should go away.
Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

Moving the review to joe. He'll be back from vacation later this week.
Attachment #734416 - Flags: review?(jmuizelaar) → review?(joe)
(Assignee)

Comment 8

5 years ago
Created attachment 735454 [details] [diff] [review]
DEBUG_joe?

quick patch to change the ifdef DEBUG_joe to ifdef DEBUG
(Assignee)

Updated

5 years ago
Attachment #735454 - Flags: review?(joe)
Comment on attachment 735454 [details] [diff] [review]
DEBUG_joe?

Review of attachment 735454 [details] [diff] [review]:
-----------------------------------------------------------------

just remove this DEBUG_joe stuff - CACHEPUT and CACHEGET were used for very, very early debugging when I rewrote the image cache, and there's no reason to spam everyone's consoles with this.
Attachment #735454 - Flags: review?(joe) → review-
Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this is totally unnecessary.
Attachment #734416 - Flags: review?(joe) → review+
(Assignee)

Comment 11

5 years ago
Created attachment 736814 [details] [diff] [review]
rebased and updated

Thanks Joe :)
Attachment #734416 - Attachment is obsolete: true
Attachment #736814 - Flags: checkin?
(Assignee)

Comment 12

5 years ago
Created attachment 736815 [details] [diff] [review]
rebased and updated

second part
Attachment #735454 - Attachment is obsolete: true
Attachment #736815 - Flags: checkin?
Attachment #736814 - Flags: checkin? → checkin+
Attachment #736815 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/f81774f097c3
https://hg.mozilla.org/mozilla-central/rev/c7fc583deeb3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.