859158 - ifdef DEBUG unused in imgRequest.cpp

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Luis de Bethencourt [:luisbg]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130311191316

Steps to reproduce:

There is an unused ifdef DEBUG, only containing a comment, around line 670 of imgRequest.cpp

#ifdef DEBUG
    /* NS_WARNING if the content type from the channel isn't the same if the sniffing */
#endif

Comment 1

[Luis de Bethencourt [:luisbg]]

Attachment: Patch to remove the unused ifdef DEBUG

Comment 2

[Luis de Bethencourt [:luisbg]]

In a related note concerning the same file. Should the line that says:
#ifdef DEBUG_joe

should be?
#ifdef DEBUG

Comment 3

[Matthias Versen [:Matti]]

Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

You should request a review from a person or you patch might be lost

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

I'll leave this to jmuizelaar to review.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't write the comment. So I'm not sure if it should go away.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

Moving the review to joe. He'll be back from vacation later this week.

Comment 7

[Luis de Bethencourt [:luisbg]]

Those lines have been there since hg@1
http://hg.mozilla.org/mozilla-central/diff/9b2a99adc05e/modules/libpr0n/src/imgRequest.cpp

Except the change s/NS_DEBUG/DEBUG in 2012
http://hg.mozilla.org/mozilla-central/rev/db9fc4c50e24

Comment 8

[Luis de Bethencourt [:luisbg]]

Attachment: DEBUG_joe?

quick patch to change the ifdef DEBUG_joe to ifdef DEBUG

Comment 9

[Joe Drew (not getting mail)]

Comment on attachment 735454 [details] [diff] [review]
DEBUG_joe?

Review of attachment 735454 [details] [diff] [review]:
-----------------------------------------------------------------

just remove this DEBUG_joe stuff - CACHEPUT and CACHEGET were used for very, very early debugging when I rewrote the image cache, and there's no reason to spam everyone's consoles with this.

Comment 10

[Joe Drew (not getting mail)]

Comment on attachment 734416 [details] [diff] [review]
Patch to remove the unused ifdef DEBUG

Review of attachment 734416 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this is totally unnecessary.

Comment 11

[Luis de Bethencourt [:luisbg]]

Attachment: rebased and updated

Thanks Joe :)

Comment 12

[Luis de Bethencourt [:luisbg]]

Attachment: rebased and updated

second part

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f81774f097c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fc583deeb3

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f81774f097c3
https://hg.mozilla.org/mozilla-central/rev/c7fc583deeb3