859181 - Variables view closes immediately on first open

Status: RESOLVED FIXED

Description

[J. Ryan Stinnett [:jryans]]

Using the tip of fx-team (rev 5e01908df6d7).

STR:

1. Open the Debugger
2. Click the button to open the variables view
3. It will open and close immediately
4. Click the button again
5. It will stay open this time

Comment 1

[Victor Porof [:vporof][:vp]]

I'm not able to reproduce this. Is this happening on a certain page? I tested with http://htmlpad.org/debugger/ and it seems to be working properly.

What OS are you on?

Comment 2

[J. Ryan Stinnett [:jryans]]

I am using OS X 10.8.3, and it happens for me on that page.

But then I just realized it doesn't happen with a clean profile.  It looks like the issue is I have "Show panes on startup" checked in the Debugger options.  When the Debugger first opens, the button to toggle panes thinks the panes are already opened, but the variables view is not shown.  So, the first click goes back to closed mode (after a brief flash of open), and then the next click actually opens it.

Disabling this option gets rid of the issue, so it seems like the real problem is that the "Show panes..." setting is not being respected properly.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> Disabling this option gets rid of the issue, so it seems like the real
> problem is that the "Show panes..." setting is not being respected properly.

Aaah!

Comment 4

[Victor Porof [:vporof][:vp]]

Created attachment 734634 [details] [diff] [review]
v1

Obviously...

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 734634 [details] [diff] [review]
v1

Review of attachment 734634 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/ViewHelpers.jsm
@@ +113,5 @@
> +
> +    // Add a class to the pane to handle min-widths, margins and animations.
> +    if (!aPane.classList.contains("generic-toggled-side-pane")) {
> +      aPane.classList.add("generic-toggled-side-pane");
> +    }

obviously.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/2e2ae594b1ac

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e2ae594b1ac