85921 - can't save more than one message in drafts folder

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[Christopher Blizzard (:blizzard)]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.2-2smp i686; en-US; rv:0.9.1+)
Gecko/20010614
BuildID:    20010614

When I save more than one message from composer the second message doesn't show
up in the drafts folder.

Reproducible: Always
Steps to Reproduce:
1. Open the composer.
2. Open the Drafts folder in your Local Mail folder.
2. Type in a sample test message.
3. Click "Save" to save the message.
4. Change something in the message.
5. Click "Save" to save the message again.

Actual Results:  Second message doesn't show up in the message list.  Depending
on whether or not you have any messages in there before the first message
sometimes the first message won't show up either.

Expected Results:  All messages in the folder should be listed in the message list.

I've tried blowing away the Drafts folder and it doesn't make a difference.  As
soon as I try to add a second message it fails to display messages.

Comment 1

[Scott MacGregor]

cavin, can you look into this? 

Comment 2

[Cavin Song]

Accepted. I'll see if I can reproduce it.

Comment 3

[Cavin Song]

Attachment: Fixed the problem.

Comment 4

[Cavin Song]

Navin, can you review the patch? It fixes the local draft problem and hope it 
doesn't break anything else.

Comment 5

[Scott MacGregor]

sr=mscott

Comment 6

[scottputterman]

moving to 0.9.2 

Comment 7

[Navin Gupta]

r=naving, cavin could you try simple cases of copying single & multiple 
messages from imap and news to local before checking in. 

Comment 8

[Cavin Song]

OK. Checked a few cases of moving msgs between folders and they all worked fine. 
But I encountered a separate problem during testing and filed bug #86018 against 
it.

Comment 9

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)-Asa

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Bug 85758 looks like a dupe.

Comment 11

[Cavin Song]

Fix checked in.

Comment 12

[Aleksey Nogin]

Take a look at bug #84905 - there we were discussing whether to return D&D
behaviour to be "always move the message" instead of "move when same server,
otherwise copy". It seems that the fixed checked in for this bug made it harder
to fix 84905 - my simple two-line fix to messagednd.js no nonger works (at least
for POP -> Local).

In short, if POP -> Local CopyMessage is requested from D&D with IsMove ==
PR_TRUE, this "fix" seems to cause it to preform a copy and not a move! And we
need to be able to do a move with D&D - the only thing that is not decided so
far is whether to do it by default (bug 84905 or when Shift is pressed - 85515).

Comment 13

[Aleksey Nogin]

Sorry, strike that, I was wrong, D&D is still working as its supposed to after
this patch. Sorry again for the spam.

Comment 14

[fenella]

Linux (200106-19-14 trunk)
Using the same scenario, the second time I save the same message over-rides the
first message even if I change the subject.
But if I close the compose, start another message, it will save the second
message.

Comment 15

[Cavin Song]

fenella, this is the right behavior because draft messages are saved based on 
the unique message ids and not the subject (or any other message fields). In 
other words, no matter what you change (subject, body text, recipients, etc.) in 
the message the second time (and hit Save), there should be only one message 
saved to the draft folder (ie, new one overrides the existing one).

If you start another compose and save the message then it'll be saved as a 
separate message becuse it now has a different unique message id than the first 
message you saved. 

Marking FIXED.

Comment 16

[esther]

Using build 2001-06-29 on win, mac and linux you can save more than one message
to the IMAP & Local drafts folder.   Note, as Cavin pointed out, if you edit a
draft message mulitiple times and save it will only save the last edited copy of
the draft msg.  The original scenario is confusing, not sure if reporter
expected the edited draft to save the edited msg as another new draft, if so
that is incorrect behavior.  Verified.