859222 - Need custom icon for Network tab

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Victor Porof [:vporof][:vp]]

We're currently reusing the Profiler icon. While that icon is absolutely lovely, the Profiler said it's upset about it and wants us to stop being copycats.

Comment 1

[Victor Porof [:vporof][:vp]]

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

Comment 2

[Victor Porof [:vporof][:vp]]

Do you have some time to work on this Stephen or shall we postpone for the next release (I somehow feel that the network monitor should be preffed off in 23)?

Comment 3

[Stephen Horlander [:shorlander]]

Yes, I can work on this. Should have something next week. 

Why do you feel it should be preffed off?

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Stephen Horlander from comment #3)
> 
> Why do you feel it should be preffed off?

I don't feel like that anymore :)

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Network Tab Icon

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 7

[Joe Walker [:jwalker]]

Comment on attachment 748377 [details] [diff] [review]
v1

Review of attachment 748377 [details] [diff] [review]:
-----------------------------------------------------------------

Code-wise this is obviously fine.
Want me to check it in?

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Joe Walker [:jwalker] from comment #7)
> Code-wise this is obviously fine.
> Want me to check it in?

Yes please!

Comment 9

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=4dbd432e7667
https://hg.mozilla.org/integration/fx-team/rev/4dbd432e7667

Although: "CLOSED. BuiltBot issues: jobs don't seem to be showing up; tbpl fails to finish loading; retriggers not working;."

Comment 10

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/4dbd432e7667