859297 - Homescreen incorrectly prevents (or does not prevent) events from firing in BrowserElementPanning

Status: RESOLVED DUPLICATE of bug 835710

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[James Lal [:lightsofapollo]]

Noticed while profiling something else:

Note there is not a scientific approach to my touch movements here but its obvious we are doing extra work during touches.

Without prevent default: 

http://people.mozilla.com/~bgirard/cleopatra/#report=0e610d5fb198d8f1a575835e56e521c8875d92ce

With prevent default:

http://people.mozilla.com/~bgirard/cleopatra/#report=2c13a45e6d0a45297920e66fd38da38003bc7510

Comment 1

[James Lal [:lightsofapollo]]

Attachment: Add preventDefault

Comment 2

[Cristian Rodriguez (:crdlc)]

please review the long press with your patch and the blue active of the icons , thanks

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 734595 [details] [diff] [review]
Add preventDefault

That sounds good if Cristian r? it too :)

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 734595 [details] [diff] [review]
Add preventDefault

Please as far as I know, Chris Jones and me were studying this issue one month ago, but we cannot did it because we are listening to contextmenu event and furthermore if we call to prevent method, the active pseudo class of the icons disappears. Please, if there is some change on gecko and currently we don't lose these features, please ask me for a new review. Sorry

Comment 5

[Cristian Rodriguez (:crdlc)]

upps sorry, I lay, jeje I did a function to implement the active pseudo class in javascript to add the stopPropagation (bug 835710)