859367 - make xpt.py use unpack_from instead of unpack

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make xpt.py use unpack_from instead of unpack

Makes the code look a bit better, might even be more efficient.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 734683 [details] [diff] [review]
make xpt.py use unpack_from instead of unpack

Review of attachment 734683 [details] [diff] [review]:
-----------------------------------------------------------------

I have no idea why I didn't write it like this in the first place.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c302ab916b3

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> I have no idea why I didn't write it like this in the first place.

Probably because unpack_from was added relatively recently (2.5) and xpt.py predates that?

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c302ab916b3

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to Nathan Froyd (:froydnj) from comment #3)
> Probably because unpack_from was added relatively recently (2.5) and xpt.py
> predates that?

I wrote pyxpt in mid-2010, so I suspect it's not that. I probably just missed this method. :)