859376 - [homescreen] fix unreliable test about panning

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Julien Wajsberg [:julienw]]

In homescreen, one test is failing only sometimes, which is not good.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

see also https://github.com/mozilla-b2g/gaia/pull/9044

Replacing setTimeout by mozRequestAnimationFrame seems to make the test more
reliable.
---
 apps/homescreen/test/unit/grid_test.js |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 734689 [details] [diff] [review]
patch v1

Perfect from my point of view

Comment 3

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/577789c2e22a239411fa156a160fbe5c9131801c

Comment 4

[Julien Wajsberg [:julienw]]

This is frustrating that the only build that fails for this test is the one for this commit :

https://travis-ci.org/mozilla-b2g/gaia/builds/6177609

will have a look again later...

Comment 5

[Cristian Rodriguez (:crdlc)]

woohh I guess that I merged it with green travis

Comment 6

[Julien Wajsberg [:julienw]]

yep travis was green on the PR.

This is an unreliable test... we can never be sure with setTimeout and requestAnimationFrame ;)

I guess I'll have to wait more time..

Comment 7

[Julien Wajsberg [:julienw]]

a=tests
pushed to v1-train: f2d67d4a3bbfa112c80d45f870a48a321f637ea3

Comment 8

[Julien Wajsberg [:julienw]]

a=tests
v1.0.1: 99f111e7caf502981ea4886a3e113b2679d6bcdb