Closed Bug 859376 Opened 11 years ago Closed 11 years ago

[homescreen] fix unreliable test about panning

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(b2g18 fixed, b2g18-v1.0.1 fixed)

RESOLVED FIXED
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

In homescreen, one test is failing only sometimes, which is not good.
Attached patch patch v1Splinter Review
see also https://github.com/mozilla-b2g/gaia/pull/9044

Replacing setTimeout by mozRequestAnimationFrame seems to make the test more
reliable.
---
 apps/homescreen/test/unit/grid_test.js |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Assignee: nobody → felash
Attachment #734689 - Flags: review?(crdlc)
Blocks: 856153
Comment on attachment 734689 [details] [diff] [review]
patch v1

Perfect from my point of view
Attachment #734689 - Flags: review?(crdlc) → review+
https://github.com/mozilla-b2g/gaia/commit/577789c2e22a239411fa156a160fbe5c9131801c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This is frustrating that the only build that fails for this test is the one for this commit :

https://travis-ci.org/mozilla-b2g/gaia/builds/6177609

will have a look again later...
woohh I guess that I merged it with green travis
yep travis was green on the PR.

This is an unreliable test... we can never be sure with setTimeout and requestAnimationFrame ;)

I guess I'll have to wait more time..
Depends on: 859732
No longer depends on: 859732
a=tests
pushed to v1-train: f2d67d4a3bbfa112c80d45f870a48a321f637ea3
a=tests
v1.0.1: 99f111e7caf502981ea4886a3e113b2679d6bcdb
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: