Closed
Bug 859425
Opened 12 years ago
Closed 12 years ago
Move decoding/storing favicons to background thread
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox20+ fixed, firefox21+ fixed, firefox22+ fixed, firefox23 fixed)
RESOLVED
FIXED
Firefox 23
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
1.55 KB,
patch
|
kats
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
The awesomescreen will load favicons in a separate, lazy task. However the Cursor holding the favicons is handed back to the UI thread where we loop over the data, decode bitmaps and store in the Favicon mem cache.
We should be doing that in the background thread. This patch moves the function call to the background thread.
Attachment #734729 -
Flags: review?(bugmail.mozilla)
Updated•12 years ago
|
Attachment #734729 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 734729 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: DB code on the UI thread can cause ANR hangs and locks. Plus we are decoding bitmaps on the UI thread instead of the background thread.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk. straight forward change
String or IDL/UUID changes made by this patch: none
Attachment #734729 -
Flags: approval-mozilla-beta?
Attachment #734729 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Assignee: nobody → mark.finkle
status-firefox21:
--- → affected
status-firefox22:
--- → affected
tracking-firefox21:
--- → +
tracking-firefox22:
--- → +
Comment 4•12 years ago
|
||
Comment on attachment 734729 [details] [diff] [review]
patch
low risk patch with stability win. Approving for beta/aurora .
Attachment #734729 -
Flags: approval-mozilla-beta?
Attachment #734729 -
Flags: approval-mozilla-beta+
Attachment #734729 -
Flags: approval-mozilla-aurora?
Attachment #734729 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 5•12 years ago
|
||
Updated•12 years ago
|
status-firefox20:
--- → affected
tracking-firefox20:
--- → +
Comment 6•12 years ago
|
||
Comment on attachment 734729 [details] [diff] [review]
patch
[Triage Comment]
We're going to take this low risk, stability win for our 20.0.1 mobile respin
Attachment #734729 -
Flags: approval-mozilla-release+
Assignee | ||
Comment 7•12 years ago
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•