859434 - Close thumbnail cursor in TopSitesView

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We never close the cursor used to load and decode a thumbnail bitmap in TopSitesView.java

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78457232611a

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78457232611a

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 734740 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Not closing cursors can lead to crashes like bug 760394
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk. simple patch
String or IDL/UUID changes made by this patch: none

Comment 4

[bhavana bajaj [:bajaj]]

Comment on attachment 734740 [details] [diff] [review]
patch

Low risk patch which can help with Bug 760394 , a DB related top-crasher.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3372fc78ea72
https://hg.mozilla.org/releases/mozilla-beta/rev/4a3af6adb8d3