Closed Bug 859440 Opened 12 years ago Closed 12 years ago

Intermittent testClearPrivateData | Exception caught - java.lang.NullPointerException

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: RyanVM, Assigned: gbrown)

Details

(Keywords: crash, intermittent-failure)

Attachments

(1 file)

guard against null ListView.getAdapter
1.40 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=21552531&tree=Mozilla-Inbound Android Armv6 Tegra 250 mozilla-inbound opt test robocop-2 on 2013-04-08 03:48:57 PDT for push eebe60eebd95 slave: tegra-060 0 INFO SimpleTest START 1 INFO TEST-START | testClearPrivateData 2 INFO TEST-PASS | testClearPrivateData | Awesomebar URL typed properly - http://mochi.test:8888/tests/robocop/robocop_blank_01.html should equal http://mochi.test:8888/tests/robocop/robocop_blank_01.html 3 INFO TEST-PASS | testClearPrivateData | checking history exists - history exists waitForText timeout on ^Settings$ 4 INFO TEST-PASS | testClearPrivateData | checking clear button - clear button exists 5 INFO TEST-PASS | testClearPrivateData | private data cleared successfully - true should equal true Exception caught during test! java.lang.NullPointerException at org.mozilla.fennec.tests.BaseTest.getAwesomeList(BaseTest.java:428) at org.mozilla.fennec.tests.BaseTest.getHistoryList(BaseTest.java:475) at org.mozilla.fennec.tests.testClearPrivateData.clearHistory(testClearPrivateData.java:42) at org.mozilla.fennec.tests.testClearPrivateData.testClearPrivateData(testClearPrivateData.java:16) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186) at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:125) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447) 6 INFO TEST-UNEXPECTED-FAIL | testClearPrivateData | Exception caught - java.lang.NullPointerException 7 INFO TEST-END | testClearPrivateData | finished in 101740ms 8 INFO TEST-START | Shutdown 9 INFO Passed: 4 10 INFO Failed: 1 11 INFO Todo: 0 12 INFO SimpleTest FINISHED
The test clears private data, then retrieves the history list to check that it is empty. In checking the history list, we find that the history ListView sometimes does not have an adapter, and that causes an npe.
Attachment #739204 - Flags: review?(jmaher)
Assignee: nobody → gbrown
Comment on attachment 739204 [details] [diff] [review] guard against null ListView.getAdapter Review of attachment 739204 [details] [diff] [review]: ----------------------------------------------------------------- oh, this is smart!
Attachment #739204 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/f39f67beae26
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: