859464 - merge final verify builders together

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[[e-mail] (:bhearsum)]

Once bug 628796 is landed, the final verify scripts will do internal parallelization. With that done we should merge the builders together rather than eating up 4 build slaves to do final verify.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: merge builders

Ran through dump masters. New final verify command is eg:
    C {'command': ['bash',  'final-verification.sh',  'mozBeta-firefox-linux.cfg',  'mozBeta-firefox-linux64.cfg',  'mozBeta-firefox-mac64.cfg',  'mozBeta-firefox-win32.cfg'], 'description': ['final-verification.sh'], 'descriptionDone': None, 'log_eval_func': None, 'logfiles': {}, 'name': 'final_verification', 'usePTY': 'slave-config', 'workdir': 'tools/release'} {'BUILDBOT_CONFIGS': 'http://hg.mozilla.org/build/buildbot-configs', 'BUILDBOTCUSTOM': 'http://hg.mozilla.org/build/buildbotcustom', 'CLOBBERER_URL': 'http://clobberer.pvt.build.mozilla.org/always_clobber.php'}


And the schedulers that have final verify as an upstream have "release-mozilla-beta-final_verification" instead of the 4 platforms.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 736843 [details] [diff] [review]
merge builders

Review of attachment 736843 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ -1465,4 @@
>              },
>          })
>  
> -    for platform in releaseConfig.get('verifyConfigs', {}).keys():

I think this won't work for first esr builds, when verifyConfigs is not set or set to {}. Can you add a guard and check that condition?

Comment 3

[[e-mail] (:bhearsum)]

Attachment: make it work with esr

Good catch! I also noticed that I missed "builderPrefix" on the name, too, causing collisions between branches.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: fix the second hunk too

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 737479 [details] [diff] [review]
fix the second hunk too

Landed on default

Comment 6

[[e-mail] (:bhearsum)]

Made it to production yesterday.