Closed Bug 859482 Opened 7 years ago Closed 7 years ago

XPCQuickStubs.cpp:117:10: warning: variable ‘definedProperty’ set but not used [-Wunused-but-set-variable]

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Last week, Bug 792215's cset removed the last usage of "definedProperty" in xpc_qsDefineQuickStubs:
 https://hg.mozilla.org/mozilla-central/rev/dc6c1d4bff95#l7.254
so now we spam this build warning:
{
js/xpconnect/src/XPCQuickStubs.cpp: In function ‘JSBool xpc_qsDefineQuickStubs(JSContext*, JSObject*, unsigned int, uint32_t, const nsIID**, uint32_t, const xpc_qsHashEntry*, const xpc_qsPropertySpec*, const xpc_qsFunctionSpec*, const char*)’:

js/xpconnect/src/XPCQuickStubs.cpp:117:10: warning: variable ‘definedProperty’ set but not used [-Wunused-but-set-variable]
}

Looks like this variable can just go away.
Attached patch fixSplinter Review
Attachment #734799 - Flags: review?(bzbarsky)
Comment on attachment 734799 [details] [diff] [review]
fix

r=me
Attachment #734799 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/53268e47c779
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.