859482 - XPCQuickStubs.cpp:117:10: warning: variable ‘definedProperty’ set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Last week, Bug 792215's cset removed the last usage of "definedProperty" in xpc_qsDefineQuickStubs:
 https://hg.mozilla.org/mozilla-central/rev/dc6c1d4bff95#l7.254
so now we spam this build warning:
{
js/xpconnect/src/XPCQuickStubs.cpp: In function ‘JSBool xpc_qsDefineQuickStubs(JSContext*, JSObject*, unsigned int, uint32_t, const nsIID**, uint32_t, const xpc_qsHashEntry*, const xpc_qsPropertySpec*, const xpc_qsFunctionSpec*, const char*)’:

js/xpconnect/src/XPCQuickStubs.cpp:117:10: warning: variable ‘definedProperty’ set but not used [-Wunused-but-set-variable]
}

Looks like this variable can just go away.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 734799 [details] [diff] [review]
fix

r=me

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53268e47c779

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/53268e47c779