859569 - Target.makeRemote should attachTab

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Dave Camp (:dcamp)]

Debugger and Web Console each attachTab on startup, but some of the framework features ("navigate" and "will-navigate") depend on an attached tab.

Target.makeRemote should just run attachTab right after it lists tabs, and console/debugger should be able to get the tab client from the target.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

If it blocks the remotable style editor, I'll get right to it. Actually I don't think the tabClient is useful to the tools anyway, which would simplify the API even more.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: WIP

This should work for the style editor and any other tool that doesn't need to do anything more with a tab than attach to it. I decided to do a broader refactoring of the remote tools, so I have broken the console and one debugger test that I'll finish tomorrow. I am moving all tab-related activities from the tools to the target and fix any tests that break.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

This version passes all tests. I'll do some more testing tomorrow before asking for review.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v3

This seems to work fine in all my testing and mochitests pass locally. Dealing with the tab is now the responsibility of the target and tools just listen for the events they care about (will-navigate, navigate, close). The only extra information obtained after attaching to a tab, the thread actor, was needed only by the JS debugger and is now being passed on.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/904b91062c25

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/904b91062c25