Closed Bug 859569 Opened 7 years ago Closed 7 years ago

Target.makeRemote should attachTab

Categories

(DevTools :: Framework, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: dcamp, Assigned: past)

References

Details

Attachments

(1 file, 2 obsolete files)

Debugger and Web Console each attachTab on startup, but some of the framework features ("navigate" and "will-navigate") depend on an attached tab.

Target.makeRemote should just run attachTab right after it lists tabs, and console/debugger should be able to get the tab client from the target.
Blocks: 816967
If it blocks the remotable style editor, I'll get right to it. Actually I don't think the tabClient is useful to the tools anyway, which would simplify the API even more.
Assignee: nobody → past
Status: NEW → ASSIGNED
Attached patch WIP (obsolete) — Splinter Review
This should work for the style editor and any other tool that doesn't need to do anything more with a tab than attach to it. I decided to do a broader refactoring of the remote tools, so I have broken the console and one debugger test that I'll finish tomorrow. I am moving all tab-related activities from the tools to the target and fix any tests that break.
Attached patch Patch v2 (obsolete) — Splinter Review
This version passes all tests. I'll do some more testing tomorrow before asking for review.
Attachment #735351 - Attachment is obsolete: true
Attached patch Patch v3Splinter Review
This seems to work fine in all my testing and mochitests pass locally. Dealing with the tab is now the responsibility of the target and tools just listen for the events they care about (will-navigate, navigate, close). The only extra information obtained after attaching to a tab, the thread actor, was needed only by the JS debugger and is now being passed on.
Attachment #735395 - Attachment is obsolete: true
Attachment #735923 - Flags: review?(dcamp)
Attachment #735923 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/904b91062c25
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.