Closed
Bug 859592
Opened 12 years ago
Closed 11 years ago
Need tests for anchored panels
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: evold)
Details
Attachments
(1 file)
Currently we don't verify that anchored panels do actually point to anchoring node. We should have tests to spot any regressions.
Priority: -- → P1
Assignee: nobody → zer0
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #768749 -
Flags: review?(jsantell)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 768749 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1066
Looks good!
Attachment #768749 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Updated•11 years ago
|
Assignee: zer0 → evold
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/a33b275a6194d43527d75bef7e47a6368e1b3abd
Bug 859592 - Need tests for anchored panels
https://github.com/mozilla/addon-sdk/commit/47edd9c3cf65cc797b71f425484460e120bffb08
Merge pull request #1066 from erikvold/859592
Bug 859592 - Adding test for anchored panels r=@jsantell
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Erik?
Flags: needinfo?(evold)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(evold)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•