Closed Bug 859625 Opened 9 years ago Closed 9 years ago

Defect - remove obsoleted nsISidebar functions

Categories

(Firefox for Metro Graveyard :: Components, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 24

People

(Reporter: Gavin, Assigned: ally)

References

Details

(Whiteboard: feature=defect c=tbd u=tbd p=1)

Attachments

(1 file)

See bug 691647. The nsISidebar addPanel, addPersistentPanel methods now no longer exist, so Metro's implementation of them in browser/metro/components/Sidebar.js should be removed.
Priority: -- → P4
Blocks: metrov1defect&change
No longer blocks: metrov1triage
Summary: remove obsoleted nsISidebar functions → Defect - remove obsoleted nsISidebar functions
Whiteboard: feature=defect c=tbd u=tbd p=0
yoink!
Assignee: nobody → ally
Blocks: metrov1it7
No longer blocks: metrov1defect&change
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
Status: NEW → ASSIGNED
They're marked not supported and mxr says there are no callers in /metro
Attachment #750038 - Flags: review?(netzen)
Comment on attachment 750038 [details] [diff] [review]
removing obsolete functions

Review of attachment 750038 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #750038 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/a45a64281b4b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
For testing and verification.
Flags: needinfo?(jbecerra)
There's really nothing to test here, and the dead code removal is pretty trivial to verify by code inspection.
Flags: needinfo?(jbecerra)
Status: RESOLVED → VERIFIED
no story to attach to. this is just code cleanup, removing something we didn't ever intend to use.
You need to log in before you can comment on or make changes to this bug.