Closed
Bug 859625
Opened 12 years ago
Closed 12 years ago
Defect - remove obsoleted nsISidebar functions
Categories
(Firefox for Metro Graveyard :: Components, defect, P4)
Firefox for Metro Graveyard
Components
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 24
People
(Reporter: Gavin, Assigned: ally)
References
Details
(Whiteboard: feature=defect c=tbd u=tbd p=1)
Attachments
(1 file)
|
780 bytes,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
See bug 691647. The nsISidebar addPanel, addPersistentPanel methods now no longer exist, so Metro's implementation of them in browser/metro/components/Sidebar.js should be removed.
|
||
Updated•12 years ago
|
Blocks: metrov1triage
|
||
Comment 1•12 years ago
|
||
p=1
|
||
Updated•12 years ago
|
Priority: -- → P4
|
|
||
Updated•12 years ago
|
Summary: remove obsoleted nsISidebar functions → Defect - remove obsoleted nsISidebar functions
Whiteboard: feature=defect c=tbd u=tbd p=0
|
|
||
Updated•12 years ago
|
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
|
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 3•12 years ago
|
||
They're marked not supported and mxr says there are no callers in /metro
Attachment #750038 -
Flags: review?(netzen)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 750038 [details] [diff] [review]
removing obsolete functions
Review of attachment 750038 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #750038 -
Flags: review?(netzen) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
|
Reporter | |
Comment 8•12 years ago
|
||
There's really nothing to test here, and the dead code removal is pretty trivial to verify by code inspection.
|
|
||
Updated•12 years ago
|
Flags: needinfo?(jbecerra)
|
||
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 9•11 years ago
|
||
no story to attach to. this is just code cleanup, removing something we didn't ever intend to use.
You need to log in
before you can comment on or make changes to this bug.
Description
•