Closed Bug 859659 Opened 10 years ago Closed 10 years ago

B2G RIL: Update EF_Email and EF_ANR in SIM contact.

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [fix-in-birch])

Attachments

(3 files, 9 obsolete files)

Part 1: Add read/writeNumberwithLength. v2
5.62 KB, patch
allstars.chh
: review+
Details | Diff | Splinter Review
Part 2: Update EF_Email and EF_ANR. v4
22.79 KB, patch
Details | Diff | Splinter Review
Part 3: xpcshell-tests. v2
15.01 KB, patch
vicamo
: review+
Details | Diff | Splinter Review 
In Bug 809726, we implemented updating EF_ADN when updating SIM contact.
This bug is filed to support updating EF_Email and EF_ANR as well.
Attached patch WIP - Part 1. (obsolete) — — Splinter Review 
Assignee: nobody → allstars.chh

        Attachment #746794 -
        Flags: review?(vyang) → review+

    
    

    
  
Comment on attachment 746794 [details] [diff] [review]
Part 1: Add read/writeNumberwithLengthOctet.

Review of attachment 746794 [details] [diff] [review]:
-----------------------------------------------------------------

The commit summary says different from actually added?

    
    

    
  
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #8)
> Comment on attachment 746794 [details] [diff] [review]
> Part 1: Add read/writeNumberwithLengthOctet.
> 
> Review of attachment 746794 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The commit summary says different from actually added?

Finally I thought writeNumberwithLengthOctet is too long and gave it up. 
I'll update the patch title, thanks

    
    

    
  


  
update patch title.

        Attachment #746794 -
        Attachment is obsolete: true

        Attachment #747837 -
        Flags: review+

    
    

    
  


  

        Attachment #746798 -
        Attachment is obsolete: true

        Attachment #746798 -
        Flags: review?(vyang)

        Attachment #747838 -
        Flags: review?(vyang)

        Attachment #747838 -
        Flags: review?(vyang) → review+

    
    

    
  


  

        Attachment #747838 -
        Attachment is obsolete: true

        Attachment #747840 -
        Flags: review+

    
    

    
  
Comment on attachment 746793 [details] [diff] [review]
Part 3: xpcshell-tests.

Review of attachment 746793 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +2414,5 @@
> +  const EMAIL_RECORD_ID = 20;
> +  const ANR0_FILE_ID = 0x4f11;
> +  const ANR0_RECORD_ID = 30;
> +  let count = 0;
> +  let oldContact = {recordId: ADN_RECORD_ID, alphaId: "test", number: "123456", email: "test@mail.com", anr0:"+654321"};

anr here should be an array.

        Attachment #746793 -
        Flags: review?(vyang)

    
    

    
  
Comment on attachment 747840 [details] [diff] [review]
Part 2: Update EF_Email and EF_ANR. v3

Review of attachment 747840 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +11887,5 @@
> +      }
> +
> +      // Case 2.
> +      if (field === USIM_PBR_EMAIL) {
> +        ICCRecordHelper.updateEmail(pbr, contact.recordId, contact.email, recordId, onsuccess, onerror);

should be ICCRecordHelper.updateEmail(pbr, recordId, contact.email, contact.recordId,...);

    
    

    
  


  

        Attachment #746793 -
        Attachment is obsolete: true

        Attachment #747853 -
        Flags: review?(vyang)

        Attachment #747853 -
        Flags: review?(vyang) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b5c76bed5fe3
https://hg.mozilla.org/mozilla-central/rev/03b8e37c5c6a
https://hg.mozilla.org/mozilla-central/rev/7ec0e93663cd
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

    
  
Blocks: 1157082

          You need to log in
          before you can comment on or make changes to this bug.