859659 - B2G RIL: Update EF_Email and EF_ANR in SIM contact.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 809726, we implemented updating EF_ADN when updating SIM contact.
This bug is filed to support updating EF_Email and EF_ANR as well.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Part 1.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Part 2.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Add read/writeNumberwithLengthOctet.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update EF_Email and EF_ANR.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: xpcshell-tests.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Add read/writeNumberwithLengthOctet.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update EF_Email and EF_ANR.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 746794 [details] [diff] [review]
Part 1: Add read/writeNumberwithLengthOctet.

Review of attachment 746794 [details] [diff] [review]:
-----------------------------------------------------------------

The commit summary says different from actually added?

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #8)
> Comment on attachment 746794 [details] [diff] [review]
> Part 1: Add read/writeNumberwithLengthOctet.
> 
> Review of attachment 746794 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The commit summary says different from actually added?

Finally I thought writeNumberwithLengthOctet is too long and gave it up. 
I'll update the patch title, thanks

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Add read/writeNumberwithLength. v2

update patch title.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update EF_Email and EF_ANR. v2

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update EF_Email and EF_ANR. v3

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 746793 [details] [diff] [review]
Part 3: xpcshell-tests.

Review of attachment 746793 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +2414,5 @@
> +  const EMAIL_RECORD_ID = 20;
> +  const ANR0_FILE_ID = 0x4f11;
> +  const ANR0_RECORD_ID = 30;
> +  let count = 0;
> +  let oldContact = {recordId: ADN_RECORD_ID, alphaId: "test", number: "123456", email: "[e-mail]", anr0:"+654321"};

anr here should be an array.

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 747840 [details] [diff] [review]
Part 2: Update EF_Email and EF_ANR. v3

Review of attachment 747840 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +11887,5 @@
> +      }
> +
> +      // Case 2.
> +      if (field === USIM_PBR_EMAIL) {
> +        ICCRecordHelper.updateEmail(pbr, contact.recordId, contact.email, recordId, onsuccess, onerror);

should be ICCRecordHelper.updateEmail(pbr, recordId, contact.email, contact.recordId,...);

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update EF_Email and EF_ANR. v4

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: xpcshell-tests. v2

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try:
https://tbpl.mozilla.org/?tree=Try&rev=3519bc83d4d3

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

http://hg.mozilla.org/projects/birch/rev/b5c76bed5fe3
http://hg.mozilla.org/projects/birch/rev/03b8e37c5c6a
http://hg.mozilla.org/projects/birch/rev/7ec0e93663cd

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5c76bed5fe3
https://hg.mozilla.org/mozilla-central/rev/03b8e37c5c6a
https://hg.mozilla.org/mozilla-central/rev/7ec0e93663cd