Closed
Bug 85968
Opened 23 years ago
Closed 23 years ago
Venkman should be able to handle JS components
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Other Applications Graveyard
Venkman JS Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterv, Assigned: rginda)
Details
Attachments
(2 files)
2.58 KB,
patch
|
Details | Diff | Splinter Review | |
1.96 KB,
patch
|
Details | Diff | Splinter Review |
but it doesn't :(. Problem is the url to the source file is actually a local path, which should be turned into a file:// url.
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
With this patch, my breakpoint is hit and I see the source :). One other problem: Venkman doesn't handle Macintosh line-endings because of the line var ary = data.split("\n"); in venkman-debugger.js. Mac would need split("\r") of course. Minor problem, I just changed my components line-endings to \n but it should probably be fixed sometime.
Comment 3•23 years ago
|
||
Moving to .split(/\s+/) could fix the mac whitespace problem. url.search (/^\w+:\/\//) == -1) is better, as it should find only protocols at the start of the URL. Axel
OS: Mac System 8.5 → All
Hardware: Macintosh → All
Assignee | ||
Comment 4•23 years ago
|
||
Well, here's what *I* think ;) 1) modify the js component loader to use the file:// url instead of the native path, as the filename associated with the JSScript* (dougt implemented nsLocalFile::GetURL on mac and unix for bug 73845.) 2) split on the meta-character for <end-of-line>, instead of a literal "\n". 3) strip out any control characters left over. I can't think of a situation where using file:// as the filename instead of a native path would cause trouble. Can anyone else?
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•23 years ago
|
||
Comment 6•23 years ago
|
||
works great for me. I can load both js components and local files allright on solaris. Axel
I can't think of a situation where using file:// as the filename instead of a native path would cause trouble. Can anyone else? Sure :-) MacOS =). you can have at least two disks w/ the same name. joy =). It should be documented in the file protocol implementation for macos.
Assignee | ||
Comment 8•23 years ago
|
||
Using a native path isn't going to solve that problem, we're storing the filename as plain text either way. hard disk:mozilla:components:foo.js is just as exposed to mac's braindead file system as file://hard+disk/mozilla/components/foo.js.
Assignee | ||
Comment 9•23 years ago
|
||
shaver/ brendan, care to sr=? dbradley, r=?
Comment 10•23 years ago
|
||
r=dbradley
sr=shaver.
Assignee | ||
Comment 12•23 years ago
|
||
Thanks muchly. Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Core → Other Applications
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•