85968 - Venkman should be able to handle JS components

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Peter Van der Beken [:peterv]]

but it doesn't :(. Problem is the url to the source file is actually a local
path, which should be turned into a file:// url.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: This helps

Comment 2

[Peter Van der Beken [:peterv]]

With this patch, my breakpoint is hit and I see the source :). One other
problem: Venkman doesn't handle Macintosh line-endings because of the line

var ary = data.split("\n");

in venkman-debugger.js. Mac would need split("\r") of course. Minor problem, I
just changed my components line-endings to \n but it should probably be fixed
sometime.

Comment 3

[Axel Hecht]

Moving to .split(/\s+/) could fix the mac whitespace problem.
url.search (/^\w+:\/\//) == -1) is better, as it should find only protocols
at the start of the URL.

Axel

Comment 4

[Robert Ginda]

Well, here's what *I* think ;)

1) modify the js component loader to use the file:// url instead of the native
path, as the filename associated with the JSScript* (dougt implemented
nsLocalFile::GetURL on mac and unix for bug 73845.)
2) split on the meta-character for <end-of-line>, instead of a literal "\n".
3) strip out any control characters left over.

I can't think of a situation where using file:// as the filename instead of a
native path would cause trouble.  Can anyone else?

Comment 5

[Robert Ginda]

Attachment: patch mozJSComponentLoader.cpp and venkman-debugger.js

Comment 6

[Axel Hecht]

works great for me. I can load both js components and local files allright on
solaris.

Axel

Comment 7

[timeless]

I can't think of a situation where using file:// as the filename instead of a
native path would cause trouble.  Can anyone else?

Sure :-) MacOS =).  you can have at least two disks w/ the same name.  joy =).  
It should be documented in the file protocol implementation for macos.

Comment 8

[Robert Ginda]

Using a native path isn't going to solve that problem, we're storing the
filename as plain text either way.  hard disk:mozilla:components:foo.js is just
as exposed to mac's braindead file system as
file://hard+disk/mozilla/components/foo.js.

Comment 9

[Robert Ginda]

shaver/ brendan, care to sr=?
dbradley, r=?

Comment 10

[David Bradley]

r=dbradley

Comment 11

[Mike Shaver (:shaver emeritus)]

sr=shaver.

Comment 12

[Robert Ginda]

Thanks muchly.  Fix checked in.