All users were logged out of Bugzilla on October 13th, 2018

Layout hosed if XUL toolbar is too wide

VERIFIED FIXED in M9

Status

P1
major
VERIFIED FIXED
20 years ago
14 years ago

People

(Reporter: akkzilla, Assigned: matt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: checkin postponed from m8 to m9)

(Reporter)

Description

20 years ago
If the XUL toolbar is too wide to fit in the browser window, the content area is
laid out too wide and is clipped on the right, which means among other things
that the vertical scrollbar isn't drawn.

For instance, running on linux with GECKO_FONT_SIZE_FACTOR=1.1 (to make the
fonts big enough to read since the Unix default is wrong), the editor toolbar is
too wide for the default page size by slightly more than one button, so the
editor init page always comes up with no scrollbar.  (I'll file a separate bug
on the editor toolbar being so wide.)

Layout of content should be independant of the size of the toolbars, since it
may be common for toolbars to be too wide to fit with the user's chosen font
size (it was certainly common in 4.*).

Updated

20 years ago
Assignee: trudelle → pinkerton
Target Milestone: M8

Comment 1

20 years ago
This problem is not limited to Linux, is it?  reassigning to pinkerton as p3
for M8

Updated

20 years ago
Hardware: PC → All

Comment 2

20 years ago
No, its a general window issue. I changed platform to "all"
David Hyatt says its happens because the window hierarchy is using boxes for
layout. Chrome and content just boxes inside the outermost window box, so its
not surprising at all. So Eric should be involved.
This doesn't sound easy to solve!
cc'ing hyatt and trudelle. why do i have this bug?
cc'ing hyatt and trudelle. why do i have this bug?

Updated

20 years ago
Assignee: pinkerton → evaughan

Comment 5

20 years ago
Reassigning to Eric.

This is a problem Eric and I have talked about before... namely that the iframe
should be allowed to shrink to zero size, even though the toolbars are too wide
for the window.

This seems like a bug in boxes to me.  Since the width is constrained to 100%,
elements should be constrained to 100% if possible.  I don't really see why
every element in a vertical box has to be laid out with the same width, e.g.,
why the iframe has to be as wide as the toolbars when the toolbars are violating
the constraint anyway.  The toolbars can be clipped since they don't fit, but
their violation of the 100% width constraint should not affect the elements that
can obey the constraint.

Right?

Comment 6

20 years ago
Boxes are actually doing the right thing. The solution is: One we can set the
min size of the toolbar to be smaller. This will allow the window to shrink
clipping the toolbar. This should be the first fix. But the real answer is to
make toolbars wrap, but this is a harder problem. I'll do the first fix and then
change the bug description.

Comment 7

20 years ago
Eric is right - we just need to set the XUL/CSS correctly. This works great in
the editor using the following CSS:
iframe#content-frame {
  min-width: 100px;
  min-height: 20px;
  height: 400px;
}

toolbox#EditorToolbars {
  min-width: 20px;
}

box#EditorStatusBar {
  min-width: 50px;
}

box#EditorProgessBox {
  min-width:30px;
}

This bug should be passed on to the appropriate owner(s) of the Browser
(and mail?) windows so they can fix their CSS.

Updated

20 years ago
Assignee: evaughan → matt

Comment 8

20 years ago
Matt you are the man!

Comment 9

20 years ago
Matt, do you have the fix ready for this one?  Should we fix it for M8 anyway?
Component: XP Toolkit/Widgets → XPApps
Priority: P3 → P1
(Assignee)

Comment 10

20 years ago
I'm testing the fix right now
(Assignee)

Comment 11

20 years ago
We are posponing this check in to M9

Updated

20 years ago
Target Milestone: M8 → M9
(Assignee)

Updated

20 years ago
Status: NEW → ASSIGNED

Updated

20 years ago
Whiteboard: checkin postponed from m8 to m9

Comment 12

20 years ago
updated status

Updated

20 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED

Comment 13

20 years ago
Actually I already fixed this and it is checked it. Notice you can make the
window smaller that the toolbar. I did this by makeing them min-width of the
toolboxes 10px.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 14

19 years ago
verified on

     1999-08-13-08 RedHat Linux 6.0 (GNOME/enlightenment)
     1999-08-13-08 WinNT 4.0 sp5
     1999-08-13-08 MacOS 8.51
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.