859768 - Add dictionary for Estonian, including dictionary license addition to about:license

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Axel Hecht [:Pike]]

We'd like to add a dictionary for Estonian, but http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/file/bf9bd258ccd2/extensions/spellcheck/hunspell/README_et.txt asks for an addition to about:license.

Gerv, can you do a patch for that?

Right now, we're asked to add it to beta, thus flagging this up to Firefox 21.

Sander, I'll need to reject the sign-off with the dictionary until we have the about:license blurb in place.

Comment 1

[bhavana bajaj [:bajaj]]

Looks like we need help from gerv as per Axel's comment above, hence passing it on.

Please make sure to get this ready before beta 3(Apr 16)/beta 4 goes to build.

Comment 2

[bhavana bajaj [:bajaj]]

(In reply to Axel Hecht [:Pike] from comment #0)
> We'd like to add a dictionary for Estonian, but
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/file/bf9bd258ccd2/
> extensions/spellcheck/hunspell/README_et.txt asks for an addition to
> about:license.
> 
> Gerv, can you do a patch for that?
> 
> Right now, we're asked to add it to beta, thus flagging this up to Firefox
> 21.
> 
> Sander, I'll need to reject the sign-off with the dictionary until we have
> the about:license blurb in place.

Axel we are assuming your sign-off's will cover QA testing .If there is anything additional needed on client side please make sure to CC & let :ashughes for help

Comment 3

[Sander Lepik]

Ping..

Comment 4

[Gervase Markham [:gerv]]

Attachment: about:license Patch v.1

Here's the about:license patch. Sorry for the delay - I've been rather busy. So if someone else can drive this to checkin, that would be awesome.

Gerv

Comment 5

[bhavana bajaj [:bajaj]]

Pike, Sander : what are the next steps here ? In terms of timeline Fx21 beta 4 is going to build tomorrow ~noon PT and this would be the last opportunity for low risk speculative fixes .

Comment 6

[Sander Lepik]

I really don't know. Axel?

Comment 7

[Axel Hecht [:Pike]]

Bhavana, Gerv summarized the steps really well, this needs someone to drive the patch.

I don't think this can make 21 still, thus marking 21wontfix.

Comment 8

[Gervase Markham [:gerv]]

The about:license patch can be checked straight in. Is there actually a patch ready to go to add the dictionary? If there is, then I don't see why we can't just check both in.

Gerv

Comment 9

[Sander Lepik]

Patch for dictionary: http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/rev/bf9bd258ccd2

Comment 10

[Sander Lepik]

http://hg.mozilla.org/releases/l10n/mozilla-beta/et/rev/bf9bd258ccd2 for beta.

Comment 11

[Axel Hecht [:Pike]]

Gerv, I'm concerned at this point, because the readme has a license that differs from what's in your patch.

Notably, http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/file/33b4be342038/extensions/spellcheck/hunspell/README_et.txt#l97

says

Whenever you use the Product, we request that you inform us by writing to the e-mail address [e-mail] or to street address listed below. 

which is rather different from the "courtesy email us of derivative work" that's in your patch? The rest of the license seems to differ in details between the readme and the license on their website, too.

Comment 12

[Gervase Markham [:gerv]]

I used the latest version of their licence, which is here:
http://www.eki.ee/eki/licence.html

As far as I can tell, the only difference is in the wording of the request (not requirement) that they be notified about derivative works. Can you see other differences?

I think it's fine to use the latest version from their website, but we can use the one from the README if you prefer.

Gerv

Comment 13

[Axel Hecht [:Pike]]

If you're fine, I'm too.

Let's get this landed then.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0727b8480480

I assume that comment 13 was an implicit r+.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0727b8480480

Comment 16

[Sander Lepik]

Mozilla 23? Why 23? Dictionary is landed in 22 and Axel rejected my sign-off. I'm not going to remove it as I see no reason why it can't be in 22.

Comment 17

[Axel Hecht [:Pike]]

We'll get to that in a second, but let's for now keep the resolutions as they should be. FIXED is just for central.

Comment 18

[Axel Hecht [:Pike]]

Comment on attachment 738406 [details] [diff] [review]
about:license Patch v.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: No dictionary for Estonian in 22, hard to update the locale without
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None, license plate change only
String or IDL/UUID changes made by this patch: None

We'd like to uplift this patch to aurora so that we can include the estonian dictionary with Firefox 22

Comment 19

[Axel Hecht [:Pike]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3391182c20b5, transplanted to aurora.

Comment 20

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF23b5 on Windows 7x64, Ubuntu 13.04 x86 and Mac OS 10.9:

Estonian Spellchecking Dictionary License was added in about:license. 
URL: about:license#hunspell-ee

Build ID: 20130711122148