859868 - Turn off <input type=range> on v22

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

There are still a few bits and pieces that need to be finished off before we can ship <input type=range>. I don't think it's worth the effort or risk to port those to aurora, so we should turn off <input type=range> for v22.

This will involve flipping the dom.experimental_forms_range to false, and removing a bunch of forms.css styling that we couldn't put behind the pref.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

This patch makes sure we enable <input type='range'> only for Aurora and Nightly builds. It will automatically be disabled for other builds.

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 735424 [details] [diff] [review]
Patch

I'm afraid this isn't enough, Mounir. See comment 0 - there are forms.css changes that need to be removed at the same time as the pref. If the pref is off, then we want the input to display like a text field, but currently it won't render anything due to the styling that removes the background, etc.

Comment 3

[Mounir Lamouri (:mounir)]

Good point Jonathan. I guess I can leave that to you then.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: patch

Actually this requires quite a lot of manual test disabling too.

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 737308 [details] [diff] [review]
patch

Review of attachment 737308 [details] [diff] [review]:
-----------------------------------------------------------------

You could also disable the pseudo-elements because those are web-facing features somehow. In another hand, it seems unlikely that any website depends on those if the input type doesn't actually work. Let say that it would be good to remove them if it isn't too hard to do so.

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 737308 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): disabling the many bugs implementing the feature
User impact if declined: a poor implementation of <input type=range>
Testing completed (on m-c, etc.): none - branch only disabling patch
Risk to taking this patch (and alternatives if risky): should be low
String or IDL/UUID changes made by this patch: none

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 737308 [details] [diff] [review]
patch

Approving the low risk patch which disables the feature on aurora(Fx22).

Comment 9

[bhavana bajaj [:bajaj]]

Adding verifyme for QA to make sure the pref is false by default once the patch lands.

Comment 10

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9766b6026f60

(In reply to Mounir Lamouri (:mounir) from comment #6)
> You could also disable the pseudo-elements because those are web-facing
> features somehow. In another hand, it seems unlikely that any website
> depends on those if the input type doesn't actually work. Let say that it
> would be good to remove them if it isn't too hard to do so.

It turned out to be pretty messy, so I didn't do that.

Comment 11

[j.j.]

This is already documented as implemented in Fx22 here:
https://developer.mozilla.org/en/docs/HTML/Element/Input
and here:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/22
and needs to change

Comment 12

[Jonathan Watt [:jwatt]]

Forgot to close this.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

This is shipping with FF23, no need to track turning it off.

Comment 14

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old