Closed Bug 859903 Opened 10 years ago Closed 10 years ago

Defect - Clean up default metro prefs

Categories

(Firefox for Metro Graveyard :: General, defect, P1)

20 Branch
x86
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: TimAbraldes, Assigned: TimAbraldes)

References

Details

(Whiteboard: feature=defect c=Install_and_setup u=browser_user p=1)

Attachments

(1 file)

Attached patch patch v1Splinter Review
Various prefs in metro.js need to be cleaned up.

These values are defined in branding and do not need to be redefined in metro.js (additionally we're redefining the URLs incorrectly since we're pointing them at mobile pages):
  app.releaseNotesURL
  app.faqURL
  app.update.promptWaitTime
  app.update.download.backgroundInterval
  app.update.interval
  app.update.url.manual
  app.update.url.details
  browser.search.param.yahoo-*

Without this cleanup (at least for the URLs), some helpful links that Metro Firefox presents to the user would point to non-existent or unhelpful pages.
I'm running this through try:
  https://tbpl.mozilla.org/?tree=Try&rev=27c7aacc77c7

I'll test the build output, and if it works as expected I'll request review, then land the 3 patches together
Assignee: nobody → tabraldes
QA Contact: jbecerra
Comment on attachment 735283 [details] [diff] [review]
patch v1

So far the patch works as expected.  Marking for review
Attachment #735283 - Flags: review?(netzen)
Attachment #735283 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/76a0a767541d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: needinfo?(mozbugs.retornam)
Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130414 Firefox/23.0

Verified by accessing all links I could find in Metro: 
Options - About: Nightly privacy
Sync - connect - show mew how (this is marked as a TO DO)

Couldn't find a way to simulate a crash or update to check other options, but all looks ok through manual inspection of those links in the patch.
Status: RESOLVED → VERIFIED
Flags: needinfo?(mozbugs.retornam)
Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Ensured that both "Show me how" and "I'm not near my computer..." links worked under "Sync" without any issues
- Ensured that "Read the Nightly privacy policy online" link worked without any issues under "About"
- Ensured that "Help (online)" opened the correct website without any issues under "Options"
- Ensured that all the links worked correctly under "about:"
- Ensured that the source link worked correctly under "about:buildconfig"
- Ensured that all the links at the bottom of "about:credits" worked without issues
- Checked several links under "about:license" and ensured they worked without issues
- Produced a crash that I added into Bug 867477 and ensured that the link worked under "about:crash"
Went through the following "Defect" for iteration #7 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-28-03-09-42-mozilla-central/

- Went through all the test cases in Comment 5 without any issues
- Went through all the test cases in Comment 6 without any issues
Went through the following "Defect" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-16-03-11-39-mozilla-central/

- Went through all the test cases that have been added in Comment 5 without any issues
- Went through all the test cases that have been added in Comment 6 without any issues
Went through the following "Defect" for iteration #12 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/

- Went through all the test cases that have been added in Comment 5 without any issues
- Went through all the test cases that have been added in Comment 6 without any issues
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.