859928 - Gecko Profiler is broken for B2G

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Dave Hylands [:dhylands]]

It looks like the Gecko Profiler was changed in bug 851748 to save the profile files to /sdcard

Under b2g, not all processes have permission to write to the sdcard, so this means that the profile data is not captured if the process doesn't have sufficient permission (i.e. the HomeScreen app doesn't have write permission to the sdcard).

It used to write the files to /data/local/tmp. Under B2G, this is the only location on the phone which is writable by any app.

The error message also says: "Fail to open profile log file."

It would be really nice if it said what the filename that failed was.

Comment 1

[Dave Hylands [:dhylands]]

Attachment: Make B2G use temporary directory rather than sdcard

I also added the filename to the error message which is printed when it's unable to save a file.

Comment 2

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/367df9ba7a51

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/367df9ba7a51