Closed Bug 859939 Opened 12 years ago Closed 12 years ago

AsyncPanZoomController has some type wrongness

Categories

(Core :: Graphics: Layers, defect)

23 Branch
All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Attached patch Some type fixupsSplinter Review
mLastEventTime is assigned to from a uint32_t value that is potentially outside the range of the int32_t, so mLastEventTime should be a uint32_t as well. I think practically this doesn't make a difference because when it is used it always get casted to a uint32_t anyway but while debugging it was displaying a negative value which was annoying. Also mPos is an int not a float.
Attachment #735311 - Flags: review?(ajones)
Attachment #735311 - Flags: review?(ajones) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: