859994 - Remove the Marketplace promo from Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for m-c

The marketplace promo should be removed from the product. We don't expect the marketplace to be ready for promotion until later in the year.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for beta

The code in beta is a bit different from m-c and m-a, so here is a separate patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for m-c v2

Removed menu and strings too

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for m-c v3

Remove the menu handler

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for beta v2

Remove menus and menu handler. Leave strings

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for release

Remove menus, promo and menu handler from release

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 735397 [details] [diff] [review]
patch for beta v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: required product change
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch: none

built and tested on beta

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 735397 [details] [diff] [review]
patch for beta v2

Approving on beta as this is a required product change and assuming this is low risk.

Please make sure to highlight any risk or unknown user impact this may have before landing.Also cc'ing QA to help with verification once this lands on Beta.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 735397 [details] [diff] [review]
patch for beta v2

landed on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/875a71336901

Notes for QA: This should remove the Marketplace promo in About Home. It should also remove the "Apps" menu item.

* Test that only Sync promo appears. Then setup Sync. Now there should be no promo. Rotate screen a bit too, to make sure the layout works.
* Test on different android versions and tablets/phones because we use different menus for each. Make sure the "Apps" menu is gone from all device menus.

Comment 9

[bhavana bajaj [:bajaj]]

mfinkle, sry about the mid-air overriding , resetting the flags as you marked :)

Comment 10

[Jonathan Kew [:jfkthame]]

Is this responsible for rc2 orange on mozilla-beta? It looks like there's a unit test that still expects the Apps item to be there. Probably a trivial fix, but someone who knows about it should have a look:

https://tbpl.mozilla.org/php/getParsedLog.php?id=21617194&tree=Mozilla-Beta

Android Tegra 250 mozilla-beta opt test robocop-2 on 2013-04-09 09:14:19 PDT for push 875a71336901
slave: tegra-192

25 INFO TEST-UNEXPECTED-FAIL | testSystemPages | Exception caught - junit.framework.AssertionFailedError: The text: ^Apps$ is not found!
04-09 16:42:47.094 I/Robocop ( 5196): 25 INFO TEST-UNEXPECTED-FAIL | testSystemPages | Exception caught - junit.framework.AssertionFailedError: The text: ^Apps$ is not found!
04-09 16:42:48.134 I/TestRunner( 5196): junit.framework.AssertionFailedError: 25 INFO TEST-UNEXPECTED-FAIL | testSystemPages | Exception caught - junit.framework.AssertionFailedError: The text: ^Apps$ is not found!
04-09 16:42:47.094 I/Robocop ( 5196): 25 INFO TEST-UNEXPECTED-FAIL | testSystemPages | Exception caught - junit.framework.AssertionFailedError: The text: ^Apps$ is not found!
04-09 16:42:48.134 I/TestRunner( 5196): junit.framework.AssertionFailedError: 25 INFO TEST-UNEXPECTED-FAIL | testSystemPages | Exception caught - junit.framework.AssertionFailedError: The text: ^Apps$ is not found!

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed fix for test:
https://hg.mozilla.org/releases/mozilla-beta/rev/e986afca5664

Comment 12

[Aaron Train [:aaronmt]]

VERIFIED FIXED on mozilla-beta (e986afca5664)

Comment 13

[Aaron Train [:aaronmt]]

VERIFIED FIXED on mozilla-release (026ee4d09662) over in bug 817775

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

I plan on landing this on m-c and aurora too

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Adjusting tracking/status to keep on top of mc and aurora

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64903706cf0c

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 735387 [details] [diff] [review]
patch for m-c v3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: they see the promo and go to the Marketplace. 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low-already on beta and release
String or IDL/UUID changes made by this patch: none

I am only removing the promo, not the "App" menu (or any strings)

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64903706cf0c

Comment 19

[Aaron Train [:aaronmt]]

Never again.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/608257be5ba4

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 22 Beta 1 (2013-05-15)
Device: Samsung Galaxy Tab 
OS:Android 4.0.4