Closed Bug 860007 Opened 12 years ago Closed 11 years ago

Provide settings for locking scroll directions

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 892684

People

(Reporter: dmitry.rojkov, Assigned: jmurdock)

Details

Attachments

(2 files, 3 obsolete files)

how scroll lock is caclulated
22.11 KB, image/png
Details
azpc: add settings for scroll locks
4.84 KB, patch
gal
: review-
Details | Diff | Splinter Review
Since touch events are inaccurate its difficult to scroll strictly up/down or left/right. The proposed solution is to introduce two settings for 1) vertical and 2) horizontal scroll locks that are tangents of adjacent angle of displacement vector or in other words are ratios between vertical offset and horizontal offset of a padding gesture. See the attached pic.
Attachment #735375 - Flags: review?(romaxa)
Attachment #735375 - Flags: review?(romaxa) → review?(bugzilla)
Attachment #735375 - Flags: review?(ajones)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 735375 [details] [diff] [review] azpc: add settings for scroll locks I will grab these reviews.
Attachment #735375 - Flags: review?(gal)
Attachment #735375 - Flags: review?(bugzilla)
Attachment #735375 - Flags: review?(ajones)
Comment on attachment 735375 [details] [diff] [review] azpc: add settings for scroll locks Checked and tested this my self... looks good to me
Attachment #735375 - Flags: review+
The updated version doesn't do recalculations for every fling time delta.
Attachment #735375 - Attachment is obsolete: true
Attachment #735375 - Flags: review?(gal)
Attachment #736456 - Flags: review?(gal)
This patch adds a new state to Axis instances (with mLocked member). But this way it's easier not to shift a viewport by accident to left/right when scrolling up/down (and vice versa).
Attachment #737388 - Flags: review?(gal)
fix coding style
Attachment #736456 - Attachment is obsolete: true
Attachment #737388 - Attachment is obsolete: true
Attachment #736456 - Flags: review?(gal)
Attachment #737388 - Flags: review?(gal)
Attachment #737514 - Flags: review?(gal)
gal any progress on reviewing these?
I will ping legal again about this. Sorry for the delay.
Comment on attachment 737514 [details] [diff] [review] azpc: add settings for scroll locks Unforrtunately at this juncture we are not able to take this patch. We will leave this bug open and assign it to someone who will update the bug when we are able to move forward with this.
Attachment #737514 - Flags: review?(gal) → review-
Assignee: nobody → jmurdock
I guess this bug can be closed now. APZ has got its own axis locking in 29.0a1
Indeed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: