860020 - PNG that used to load correctly now just prints the filename, and posts "Image corrupt or truncated" to error console

Status: VERIFIED DUPLICATE of bug 857040

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase (just a .png file)

STR:
 1. Load attachment

EXPECTED RESULTS: image displays. (it's a screenshot of DOM inspector, or something)

ACTUAL RESULTS:
 - we print a blue background with the URL of the file printed on top of it
 - Error console says "Image corrupt or truncated"

In current beta (ver 21), we get EXPECTED RESULTS.
In current aurora (ver 22) and Nightly, we get ACTUAL RESULTS.

Nightly UA string: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20130408 Firefox/23.0

mozregression gives this range:
{
Last good nightly: 2013-03-21
First bad nightly: 2013-03-22
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1d6fe70c79c5&tochange=0e9badd3cf39
}
which includes bug 716140. Seems like that that bug or something related to it is the culprit here.

Comment 1

[Daniel Holbert [:dholbert]]

(Note that it does look like there's some sort of issue with the JPG file -- my local image viewer, "eog", says the following when I try to open it:
> Could not load image [filename]
> Error interpreting JPEG image file (Not a JPEG file: starts with 0x89 0x50)

So this could be a case where we've just gotten stricter about our requirements for JPEG files.

Comment 2

[Daniel Holbert [:dholbert]]

(on the other hand, gimp and ImageMagick can open the jpg file just fine)

Comment 3

[Boris Zbarsky [:bzbarsky]]

0x89 0x50 is the PNG magic number.  In fact, that file is a PNG file (and the server says so, too; it's served as image/png from https://www.evernote.com/shard/s2/sh/4ea41054-3187-4bba-90ee-2b07a24daa2b/41a0a81f5b1405f238e91ab95e058cc2/deep/0/Screenshot%204/9/13%2012:20%20PM.jpg ).

Comment 4

[Daniel Holbert [:dholbert]]

Ah, gotcha - thanks for noticing/fixing that!  The "jpg" extension in the URL is what threw me off, and it's a red herring anyway -- we can't load it even with the correct extension / mimetype.

So -- with that local file-rename, eog now loads the file correctly, and Firefox nightly & Aurora are the only programs I have that can't load it.

Comment 5

[Daniel Holbert [:dholbert]]

Requesting tracking for Firefox 22, since this is a regression on that train right now, preventing some images from rendering properly.

Comment 6

[Alex Keybl [:akeybl]]

Yep - this should be fully understood before shipping FF22.

Comment 7

[Seth Fowler [:seth] [:s2h]]

I am taking a preliminary look at this right now. Will leave assigned to Joe until I determine if I can fix it or not. =)

Comment 8

[Jesse Ruderman]

Another broken one:

https://www.evernote.com/shard/s4/sh/7aee9ff3-ab7b-40bb-abbb-51f369918ddd/58ca49b9c6b4479d7c2cb1e66f933be4/deep/0/Screenshot%204/12/13%209:43%20PM.jpg

(Also a screenshot on Evernote, also a PNG misnamed as JPG.)

Comment 9

[Jesse Ruderman]

(Older bug has more technical info and less confusion in the comments.  Newer bug has tracking flags and regression info.)

Comment 10

[Jesse Ruderman]

Attachment: PNG file from comment 8

Comment 11

[Glenn Randers-Pehrson]

verified dupe.  The file has an ancillary chunk with invalid (0000) CRC after the IDAT chunk.