860078 - hard to monitor status of release-being-started via ship-it

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[hwine]

When kicking off 21.0b2, I found it difficult to update the web page for the latest status. In the new UI, displaying the "completed section" isn't a state preserved, so every refresh requires two clicks and a bunch of mousing to show the page.

I don't recall having this issue in the past, and the web colors seemed different - this might be a regression.

Comment 1

[[e-mail] (:bhearsum)]

Massimo, can you take a look at this when you have time? It's not super urgent, but definitely a regression we should fix.

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: Storing current accordion, tab and table sorting locally

Current status (active accordion, tab and table sorting) is preserved when refreshing the page.

Changes in this patch:

* added jquery.cookie.js and license file
* current tab and active accordion are saved in a cookie
* dataTables settings are saved using localStorage

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 745540 [details] [diff] [review]
Storing current accordion, tab and table sorting locally

Review of attachment 745540 [details] [diff] [review]:
-----------------------------------------------------------------

You're using cookies for part of this, and localStorage for another part. Is there a reason you can't use localStorage for both?

::: kickoff/static/kickoff.js
@@ +7,5 @@
> +  });
> +
> +  $( "#accordion" ).accordion({
> +    heightStyle: "content",
> +    navigation: true,

I don't see a reference to this in the docs (http://api.jqueryui.com/accordion/) - what is it for?

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: removing deprecated option, removed jquery.cookie.js

Yes Ben, your are right.

* removed navigation option from accordion initialization (it is deprecated)
* now using localStorage instead of external jquery.cookie library (removed)

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 746002 [details] [diff] [review]
removing deprecated option, removed jquery.cookie.js

Review of attachment 746002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good now! I'll get this landed.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 746002 [details] [diff] [review]
removing deprecated option, removed jquery.cookie.js

I pushed this to stage and prod. Thanks Massimo!