860089 - Find in Page bar using old theme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

It should be updated to match the navigation and tab bar in respect to the current theme.

--
LG Nexus 4 (Android 4.2.2)
Nightly (04/09)

Comment 1

[Sriram Ramasubramanian [:sriram]]

It was done to match the IME (in most cases). This was never made to match the themes.

Comment 2

[:Margaret Leibovic]

Ian, do you have designs for this?

Comment 3

[Ian Barlow (:ibarlow)]

The only difference here would be a new background colour and new icons. I'll post them later today.

Comment 4

[Ian Barlow (:ibarlow)]

Here are the updated icons: http://cl.ly/2u3N2h3G0k47

Also, the toolbar background and selection colour should match the ones used in the tab tray title bar.

Comment 5

[Wesley Johnston (:wesj)]

This should be a fairly straightforward chance to look through some of our java code/resources.

Comment 6

[Shilpan Bhagat]

Attachment: Visual Changes to the find in page bar to match the current theme

-Changed the relevant images in the resources to match the current theme
-Changed the background of the 'find in page' bar to tabs tray color scheme

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 761197 [details] [diff] [review]
Visual Changes to the find in page bar to match the current theme

Nice. Good first patch! :)

Comment 8

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/216620b31732

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/216620b31732