The default bug view has changed. See this FAQ.

Find in Page bar using old theme

RESOLVED FIXED in Firefox 24

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aaronmt, Assigned: Shilpan Bhagat)

Tracking

Trunk
Firefox 24
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ui-hackathon)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
It should be updated to match the navigation and tab bar in respect to the current theme.

--
LG Nexus 4 (Android 4.2.2)
Nightly (04/09)
It was done to match the IME (in most cases). This was never made to match the themes.
Flags: needinfo?(ibarlow)

Updated

4 years ago
Whiteboard: ui-hackathon

Comment 2

4 years ago
Ian, do you have designs for this?
The only difference here would be a new background colour and new icons. I'll post them later today.
Flags: needinfo?(ibarlow)
Here are the updated icons: http://cl.ly/2u3N2h3G0k47

Also, the toolbar background and selection colour should match the ones used in the tab tray title bar.
This should be a fairly straightforward chance to look through some of our java code/resources.
Assignee: nobody → sbhagat
(Assignee)

Comment 6

4 years ago
Created attachment 761197 [details] [diff] [review]
Visual Changes to the find in page bar to match the current theme

-Changed the relevant images in the resources to match the current theme
-Changed the background of the 'find in page' bar to tabs tray color scheme
Attachment #761197 - Flags: review?(sriram)
Comment on attachment 761197 [details] [diff] [review]
Visual Changes to the find in page bar to match the current theme

Nice. Good first patch! :)
Attachment #761197 - Flags: review?(sriram) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/216620b31732
https://hg.mozilla.org/mozilla-central/rev/216620b31732
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.