Last Comment Bug 860089 - Find in Page bar using old theme
: Find in Page bar using old theme
Status: RESOLVED FIXED
ui-hackathon
:
Product: Firefox for Android
Classification: Client Software
Component: Theme and Visual Design (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: Firefox 24
Assigned To: Shilpan Bhagat
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-09 16:34 PDT by Aaron Train [:aaronmt]
Modified: 2013-06-12 05:55 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Visual Changes to the find in page bar to match the current theme (14.00 KB, patch)
2013-06-11 15:38 PDT, Shilpan Bhagat
sriram.mozilla: review+
Details | Diff | Splinter Review

Description Aaron Train [:aaronmt] 2013-04-09 16:34:20 PDT
It should be updated to match the navigation and tab bar in respect to the current theme.

--
LG Nexus 4 (Android 4.2.2)
Nightly (04/09)
Comment 1 Sriram Ramasubramanian [:sriram] 2013-04-09 21:58:15 PDT
It was done to match the IME (in most cases). This was never made to match the themes.
Comment 2 :Margaret Leibovic 2013-04-23 15:33:46 PDT
Ian, do you have designs for this?
Comment 3 Ian Barlow (:ibarlow) 2013-04-24 05:49:18 PDT
The only difference here would be a new background colour and new icons. I'll post them later today.
Comment 4 Ian Barlow (:ibarlow) 2013-04-24 07:51:40 PDT
Here are the updated icons: http://cl.ly/2u3N2h3G0k47

Also, the toolbar background and selection colour should match the ones used in the tab tray title bar.
Comment 5 Wesley Johnston (:wesj) 2013-06-11 10:30:09 PDT
This should be a fairly straightforward chance to look through some of our java code/resources.
Comment 6 Shilpan Bhagat 2013-06-11 15:38:15 PDT
Created attachment 761197 [details] [diff] [review]
Visual Changes to the find in page bar to match the current theme

-Changed the relevant images in the resources to match the current theme
-Changed the background of the 'find in page' bar to tabs tray color scheme
Comment 7 Sriram Ramasubramanian [:sriram] 2013-06-11 16:32:04 PDT
Comment on attachment 761197 [details] [diff] [review]
Visual Changes to the find in page bar to match the current theme

Nice. Good first patch! :)
Comment 8 Sriram Ramasubramanian [:sriram] 2013-06-11 19:06:35 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/216620b31732
Comment 9 Ed Morley [:emorley] 2013-06-12 05:55:48 PDT
https://hg.mozilla.org/mozilla-central/rev/216620b31732

Note You need to log in before you can comment on or make changes to this bug.