860104 - We should cast the interpolated prefs written to user.js

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

We currently don't cast the interpolated prefs written to user.js by runtestsb2g.py; as a result, we get invalid statements like:

user_pref("dom.mozBrowserFramesEnabled", "false");

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Cast prefs after interpolation,

If we are going to be using this pattern a lot elsewhere, maybe it should live as a separate class method in mozprofile?

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 735495 [details] [diff] [review]
Cast prefs after interpolation,

Review of attachment 735495 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, my mistake. I thought gecko's preference parsing would be smart enough to cast 'true' to true.

And yes I was planning to move this interpolation pattern to mozbase, either as a mozprofile classmethod or part of the moztest integration layer once we get around to implementing it. I stuck it here for now as it is the only place doing this, but I'll be refactoring it out once some other harnesses start using the same method.

Comment 3

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc8ae226ad99

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc8ae226ad99