Closed Bug 860132 Opened 12 years ago Closed 12 years ago

Ratings API does not provide "for_old_version" field

Categories

(Marketplace Graveyard :: API, defect, P1)

Product:
Marketplace Graveyard
Component:
API
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-04-18

People

(Reporter: basta, Assigned: chuck)

References

Details

(Whiteboard: [fireplace] p=1)

for_old_version returns either null/false if the rating was left on the app for the most recent version of the app, or a version number (as a string) if the rating was left for a version which is not the most recent version of the app.
Blocks: 859511
Status: NEW → ASSIGNED
OS: Mac OS X → All
QA Contact: charmston
Hardware: x86 → All
Assignee: nobody → charmston
QA Contact: charmston
wouldn't it make sense just to return the version the rating was for and let the client calculate if its old?
If the user is deep linked to the ratings page, we don't know what the current version is.
Fair enough, having the version it was rated for seems like it could be useful to others. Could we just add in for_version as well as for_old_version.
I have no problem with that.
Landed: https://github.com/mozilla/zamboni/commit/e5d8eb8eaa811f506a819beba0a1dd7eb75a0028 Docs for `version`: https://zamboni.readthedocs.org/en/latest/topics/api/ratings.html
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-04-18
Whiteboard: p=1
Whiteboard: p=1 → [fireplace] p=1
You need to log in before you can comment on or make changes to this bug.