860161 - [Settings] Input box of PIN code screen strange

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : [UI] Strange UI in PIN changing menu in Settings 
2. Precondition : Insert SIM card with PIN code set
3. Tester's Action : 
 1) Go to Settings menu and try to change PIN. Observe the PIN changing UI.
4. Detailed Symptom (ENG.) : On PIN changing screen there are strange tebales and no cursor is blinking when I click on one of them
5. Expected : UI should be more user friendly
6. Mozilla build ID : 20130318070202

Comment 1

[Leo]

Attachment: screen capture

Comment 2

[Leo]

The below code should be merged into v1-train.

\apps\settings\style\simcard.css

#simpin-dialog .input-wrapper input[type="number"] {
  border: none;
  padding: 0;
  height: 4rem;
  background: transparent;
}

Comment 3

[Alex Keybl [:akeybl]]

(In reply to leo.bugzilla.gaia from comment #2)
> The below code should be merged into v1-train.
> 
> \apps\settings\style\simcard.css
> 
> #simpin-dialog .input-wrapper input[type="number"] {
>   border: none;
>   padding: 0;
>   height: 4rem;
>   background: transparent;
> }

Can comment 2 be attached as a patch? A good reviewer would be Evelyn Hung when ready.

Comment 4

[Leo]

The below code already merged into master.
It's included the patch code of Bug 830644
https://github.com/mozilla-b2g/gaia/commit/0f3a6c729085e322502c05b5dc932bf27ea0139c

Please check and land into v1-train also.

> \apps\settings\style\simcard.css
> 
> #simpin-dialog .input-wrapper input[type="number"] {
>   border: none;
>   padding: 0;
>   height: 4rem;
>   background: transparent;
> }

Comment 5

[Fabien Cazenave [:kaze]]

It’s a leo+, I’ll uplift that ASAP.

Comment 6

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

I’ve just had a look at bug 830644, it’s not a leo+ one and it involves huge patches that we don’t want to uplift right now. So here’s a small patch against v1-train, as suggested above.

Comment 7

[Evelyn Hung]

Comment on attachment 739567 [details]
link to pull request

I believe I've resolve the issue in bug 861215(leo+) with the commit landed in v1-train: 
https://github.com/mozilla-b2g/gaia/commit/93d953aa36cc6ec756271d9fa9004f24c6bb8f52

Comment 8

[Evelyn Hung]

Resolved in bug 861215(leo+)

commit number landed in v1-train: 
https://github.com/mozilla-b2g/gaia/commit/93d953aa36cc6ec756271d9fa9004f24c6bb8f52