Closed
Bug 860171
Opened 12 years ago
Closed 12 years ago
Re-add SendRingIndicator on b2g18
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:tef+, firefox21 unaffected, firefox22 unaffected, firefox23 unaffected, b2g18 fixed, b2g18-v1.0.0 unaffected, b2g18-v1.0.1 unaffected)
| Tracking | Status | |
|---|---|---|
| firefox21 | --- | unaffected |
| firefox22 | --- | unaffected |
| firefox23 | --- | unaffected |
| b2g18 | --- | fixed |
| b2g18-v1.0.0 | --- | unaffected |
| b2g18-v1.0.1 | --- | unaffected |
People
(Reporter: qdot, Assigned: qdot)
Details
Attachments
(1 file, 1 obsolete file)
|
4.24 KB,
patch
|
gyeh
:
review+
|
Details | Diff | Splinter Review |
In bug 851046, one of the patches on b2g18 overstepped a bit and removed the way we indicate rings to a headset. We need to add this back.
|
Assignee | |
Comment 1•12 years ago
|
||
Ok. Rebased to before HfpManager merge on b2g18, undid the SendRingIndicator removal in that patch, repatched on top of it, then diff'd against what's in upstream b2g18 now.
Attachment #735615 -
Flags: review?(gyeh)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 735615 [details] [diff] [review]
Patch 1 (v1) - Readd ring indicator for Bluetooth HFP
Nevermind. Doesn't build.
Attachment #735615 -
Attachment is obsolete: true
Attachment #735615 -
Flags: review?(gyeh)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Missed a step the first time. Same procedure as last time, plus remembering to apply patch portions from m-c HfpManager changes to actually use new SendLine calls.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 735618 [details] [diff] [review]
Patch 1 (v2) - Readd ring indicator for Bluetooth HFP
Ok, /now/ it's ready for review.
I think I see what happened in the b2g18 merge too. There were a couple of conflicts between b2g18 and HfpManager on this, and I think I let it pick all the prior b2g18 hunks then went through and hand picked the socket changes out of the bluetoothsocket patch. So it just chose nothing for the conflicted Hfp portion and I went with it. Who needs ringing anyways?
Attachment #735618 -
Flags: review?(gyeh)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 735618 [details] [diff] [review]
Patch 1 (v2) - Readd ring indicator for Bluetooth HFP
Review of attachment 735618 [details] [diff] [review]:
-----------------------------------------------------------------
I'd like to ask you for helping on what you did in v2 patch, and then I saw your new patch. :D
Thanks for making it better, Kyle.
Attachment #735618 -
Flags: review?(gyeh) → review+
|
||
Updated•12 years ago
|
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → unaffected
status-b2g18-v1.0.1:
--- → unaffected
status-firefox21:
--- → unaffected
status-firefox22:
--- → unaffected
status-firefox23:
--- → unaffected
|
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Readd SendRingIndicator on b2g18 → Re-add SendRingIndicator on b2g18
Target Milestone: --- → B2G C4 (2jan on)
|
||
Comment 8•12 years ago
|
||
Was v1.0.1 marked as unaffected intentionally Ryan?
Flags: needinfo?(ryanvm)
|
|
||
Comment 9•12 years ago
|
||
Yes. This was a bug in the b2g18 patches for bug 851046 that was fixed before uplifting to v1.0.1.
Flags: needinfo?(ryanvm)
|
|
||
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•