Closed Bug 860186 Opened 13 years ago Closed 6 years ago

If xpinstall.enabled=false, then AddonInstall should deny the ability to proceed with an install - but only if not an upgrade

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INACTIVE

People

(Reporter: Unfocused, Unassigned)

References

Details

Like bug 668999, but at the API level. If xpinstall.enabled=false is set, AddonInstall should deny the install by: * AddonInstall.state should be AddonManager.STATE_DENIED or something * AddonInstall.install() should throw if called when .state=STATE_DENIED ... but only when the install is not an upgrade to an existing installed add-on. The trouble is, sometimes we don't know that an add-on is an upgrade until we've downloaded the file and parsed the install.rdf. So AddonInstall.install() needs to detect that, fire an event (onInstallDenied?), and set AddonInstall.state. An alternative method would be to just not allow creation of an AddonInstall... but as mentioned above, we don't always know that an install is an upgrade until after the file is downloaded :\
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.