860296 - Visual tearing on navigation bar during address bar resize animation

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

See screenshot. This looks jarring as the tears are quite visible during the resize animation (backing out from the AwesomeScreen). 

--
LG Nexus 4 (Android 4.2.2)
Nightly (04/10)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (04/10) - Screenshot

Comment 2

[Lucas Rocha (:lucasr)]

Sriram, looks like a regression from bug 848719?

Comment 3

[Sriram Ramasubramanian [:sriram]]

I've seen this in the past. The only change my patch did is to remove the "dark tabs fake layer" behind the tabs button. Do we want to add that back? That's clearly an overdraw. This feels like the elements are dropping frames while animating,

Comment 4

[Sriram Ramasubramanian [:sriram]]

(Resolving cat and mouse game)
Here are the options:
1. Have a dummy dark layer and show/hide it only for animation. This would ensure that there is a static  dark background behind the buttons a blue line won't be seen ever.
  - This would still show a 1px line in case of personas. A small gap can make the image go out of sync (just like now).

2. Re-order the BrowserToolbar in such a way that only the url-bar-background has a curve (currently both the url-bar-bg and tabs-button have). This way the background for the tabs and menu button will come from a dummy layer behind it. But the catch is, the tabs and menu button should be beneath the url-bar-background for this to work. That way the "pressed" state will have the curve cut off properly (than being showed over the url-bar-bg).
  - Focusing re-order issues might crop up.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Second option cannot work. There is still screen corruption due to the animation of the url-bar.

Comment 6

[Lucas Rocha (:lucasr)]

Works for me. Aaron, feel free to reopen if you can still reproduce this.