860357 - Use sqlite3_get_autocommit instead of manually tracking transactions

Status: RESOLVED DUPLICATE of bug 1613835

(Toolkit :: Storage, defect, P3)

Description

[Richard Newman [:rnewman]]

Follow on from Bug 856925.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

to add some details, we are currently tracking transactions through the calls to beginTransactionInternal, commit and rollback... This is very bogus cause it doesn't take into account externally created transactions and savepoints.
It also causes related bugs like bug 559659.

Short, our transactions management is broken.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Marco Bonardo [:mak] (needinfo? me) from comment #1)
> Short, our transactions management is broken.

Agreed.

Comment 3

[Lina Butler [:lina]]

7 years later, we did this in bug 1613835. 😁 Our transaction management story is still Not Great™️, bug 1619480 has a summary.