[ImageContainedChild] leaking SharedImage objects in ImageBridgeCopyAndSendTask::Run()

RESOLVED FIXED in B2G C4 (2jan on)

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mikeh, Assigned: mikeh)

Tracking

unspecified
B2G C4 (2jan on)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, firefox20 unaffected, firefox21 unaffected, firefox22 unaffected, firefox23 unaffected, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

(Whiteboard: [MemShrink], QARegressExclude)

Attachments

(1 attachment)

Created attachment 735874 [details] [diff] [review]
delete SharedImage object in ImageBridgeCopyAndSendTask::Run() to prevent leak

Moving patch from bug 846903 to its own bug; propagating flags, setting as blocker.
Attachment #735874 - Flags: review?(nical.bugzilla)
Comment on attachment 735874 [details] [diff] [review]
delete SharedImage object in ImageBridgeCopyAndSendTask::Run() to prevent leak

Carrying over r=nical from bug 846903 attachment 735850 [details] [diff] [review].
Attachment #735874 - Flags: review?(nical.bugzilla) → review+
blocking-b2g: tef? → tef+
jlebar, if you (or someone else) can tef+ this, I'll land it on b2g18 this afternoon.
blocking-b2g: tef+ → tef?
Flags: needinfo?(justin.lebar+bug)
No longer blocks: 846903
Whiteboard: [MemShrink]
Blocks: 846903
I tef+'ed it, but then bugzilla reverted it along with your comment!
Flags: needinfo?(justin.lebar+bug)
blocking-b2g: tef? → tef+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/70481b9a9db5

(Change _only_ applies to b2g18 branches.)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/389e5dd939c0
status-b2g18: affected → fixed
status-b2g18-v1.0.0: affected → wontfix
status-b2g18-v1.0.1: affected → fixed
status-firefox-esr17: affected → ---
Target Milestone: --- → B2G C4 (2jan on)
tracking-b2g18: ? → ---
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
Flags: needinfo?
(In reply to croesch from comment #6)
>
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?

There is no way to blackbox this from the UI.  The symptoms of the leak this fixes can only really be seen from the adb-shell command line.
Flags: needinfo?
Based on Comment 7, marking as QARegressExclude.
Whiteboard: [MemShrink] → [MemShrink], QARegressExclude
You need to log in before you can comment on or make changes to this bug.