860395 - [ImageContainedChild] leaking SharedImage objects in ImageBridgeCopyAndSendTask::Run()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: delete SharedImage object in ImageBridgeCopyAndSendTask::Run() to prevent leak

Moving patch from bug 846903 to its own bug; propagating flags, setting as blocker.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 735874 [details] [diff] [review]
delete SharedImage object in ImageBridgeCopyAndSendTask::Run() to prevent leak

Carrying over r=nical from bug 846903 attachment 735850 [details] [diff] [review].

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

jlebar, if you (or someone else) can tef+ this, I'll land it on b2g18 this afternoon.

Comment 3

[Justin Lebar (not reading bugmail)]

I tef+'ed it, but then bugzilla reverted it along with your comment!

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/70481b9a9db5

(Change _only_ applies to b2g18 branches.)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/389e5dd939c0

Comment 6

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to croesch from comment #6)
>
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?

There is no way to blackbox this from the UI.  The symptoms of the leak this fixes can only really be seen from the adb-shell command line.

Comment 8

[Cody Roesch [:croesch]]

Based on Comment 7, marking as QARegressExclude.