860419 - Let users enable add-on for private browsing

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

SDK add-on should have a pref defaulting to `false` that when set to `true` will enable add-on for private windows as well. If it's not set to `true` add-on wonn't be aware of private windows.

In long term we should probably migrate SDK approach to a platform and make private browsing windows unreachable by default and only reachable by opt-in. Also enhance
guidelines & enforce at the review level to query for private windows only if add-on
is pref is set to `true`. Add-on manager also could get some UI to enable / disable add-ons in the private browsing.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/938

Pointer to Github pull-request

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 781285 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/938

Work in progress patch.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Mossop I think this bug needs an owner and we should probably put it on weekly priority work list.

Comment 4

[Dave Townsend [:mossop]]

It'd like to revisit this in triage

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Hey Irakli, are you working on this one? if not could you please unassign yourself.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562