Closed Bug 860454 Opened 8 years ago Closed 8 years ago

UpdateService failing with java.net.URISyntaxException

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: nalexander, Assigned: bnicholson)

References

Details

Attachments

(1 file)

This is with a Fennec built a few hours ago, based on hg revision

https://hg.mozilla.org/integration/mozilla-inbound/rev/49b44cd1cdb1

The space in the URI is "obviously" wrong.

I UpdateService(25085)        openning connection with url: https://aus2.mozilla.org/update/4/Fennec/23.0a1/20130410111658/Android_ arm-eabi-gcc3/en-US/default/4.0.3/default/default/23.0a1/update.xml
E UpdateService(25085)        failed to check for update: 
E UpdateService(25085)        java.net.URISyntaxException: Illegal character in path at index 71: https://aus2.mozilla.org/update/4/Fennec/23.0a1/20130410111658/Android_ arm-eabi-gcc3/en-US/default/4.0.3/default/default/23.0a1/update.xml
E UpdateService(25085)        	at libcore.net.UriCodec.validate(UriCodec.java:63)
E UpdateService(25085)        	at java.net.URI.parseURI(URI.java:402)
E UpdateService(25085)        	at java.net.URI.<init>(URI.java:204)
E UpdateService(25085)        	at java.net.URL.toURI(URL.java:497)
E UpdateService(25085)        	at org.mozilla.gecko.updater.UpdateService.openConnectionWithProxy(UpdateService.java:278)
E UpdateService(25085)        	at org.mozilla.gecko.updater.UpdateService.findUpdate(UpdateService.java:292)
E UpdateService(25085)        	at org.mozilla.gecko.updater.UpdateService.startUpdate(UpdateService.java:191)
E UpdateService(25085)        	at org.mozilla.gecko.updater.UpdateService.registerForUpdates(UpdateService.java:161)
E UpdateService(25085)        	at org.mozilla.gecko.updater.UpdateService.onHandleIntent(UpdateService.java:116)
E UpdateService(25085)        	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
E UpdateService(25085)        	at android.os.Handler.dispatchMessage(Handler.java:99)
E UpdateService(25085)        	at android.os.Looper.loop(Looper.java:137)
E UpdateService(25085)        	at android.os.HandlerThread.run(HandlerThread.java:60)
I UpdateService(25085)        no update available
Flags: in-testsuite?
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #735944 - Flags: review?(mark.finkle)
Blocks: 856163
Comment on attachment 735944 [details] [diff] [review]
Remove space from UpdateServiceHelper

Please land on m-c to reduce the time to get in a nightly
Attachment #735944 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/a6fb03a70c9d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Duplicate of this bug: 861845
In the future it would be good to get updates turned off temporarily in these situations, to avoid stranding portions of our user base on builds with issues like the one described here. RelEng can do this very quickly if you drop by #releng or file a blocker bug in mozilla.org: Release Engineering the next time something like this comes up.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.