860462 - [Keyboard] add auto-correction UX

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

I'm creating this bug for the patch that enables auto-correction by hooking up the prediction engine to the keyboard.

This is just one of many bugs auto-correct bugs under the umbrella of meta-bub 797170, however.

Comment 1

[David Flanagan [:djf]]

Attachment: link to patch on github

Comment 2

[David Flanagan [:djf]]

The patch is intended to enable autocorrect so we can have something to test and improve.  There are lots of improvements still to be made to the back-end prediction engine.  And there are probably UX improvements to be made as well.  

So this is just a start.  Any auto-correction related bugs should be linked to the meta bug 797170.

Comment 3

[David Flanagan [:djf]]

Gregor,

I've updated the patch to fix the bug you found and to change the misleading variable name.

Comment 4

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/132c5a712ec4d4e92208ba4fc65ca98b8be00b31

Comment 5

[William Hsu [:whsu]]

Hi, all,

Thanks for your effort and help!
I used following cases to verify this new feature/UX.
(1) Disable word suggestion and auto correction.
(2) Enable word suggestion but disable auto correction.
(3) Enable word suggestion and auto correction.
(4) Disable word suggestion but enable auto correction.
As attach pictures, the new feature work as normal. I didn't find any side effect.
Thanks!

* Test build: (Mozilla-central-unagi/2013-04-14-03-06-04)
  - Mercurial-Information
    + Gecko revision="a3dad9390a30"
    + Gaia revision="288955e2758b"
  - Git-Information
    + Gecko revision="28701956b634c7bd9bb05f19533e4b744e9a9600"
    + Gaia revision="3fa788342953f33ab980fa1ba28deba1a1b8e650"

By the way, if I find any auto correction problem, I will add comment to Bug 860550.
Thanks! Have a nice day!

Comment 6

[William Hsu [:whsu]]

Attachment: New Keyboard Settings - Auto correction

Comment 7

[William Hsu [:whsu]]

Attachment: Scenarios for auto correction

Comment 8

[David Flanagan [:djf]]

Preemptively asking for leo+ all the bugs blocking the keyboard auto-correct umbrella bug 797170.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

seem like a product/UX decision whether we need auto-correct in 1.1

Comment 10

[Peter Dolanjski [:pdol]]

Chris is driving keyboard improvement decisions.

Comment 11

[Chris Lee [:clee]]

We should only land this once this has been reviewed by UX/Product/Engineering from a quality/consistency perspective.   

Can we land this on master and so we can have QA and others testing this first and then decide if we want to uplift to v1-train?

Comment 12

[William Hsu [:whsu]]

Hi, Chris,

Actually, the feature has landed on master branch.
I did a smoke test on this feature to make sure it doesn't make any side effect but not yet created test cases.
Please refer to comment 5, comment 6, and comment 7.
If we want to land this feature on v1-train, we may inform QAs to run full-run test on it.
Thanks!

Comment 13

[Wayne Chang [:wchang]]

Per comment 11 and comment 12, requesting UX/Product/QA to review auto-correction quality/performance before deciding if this is good enough for 1.1.

Comment 14

[Jason Smith [:jsmith]]

The testing itself was already done in comment 5 to check if it was safe for uplift at a sanity level. comment 12 refers to adding test cases and doing more testing, which should not block an uplift.

Comment 15

[Wayne Chang [:wchang]]

Altering NI to new FFOS UX address.

Comment 16

[Mike Lee [:mlee]]

Tracking since this change is wanted by UX but quality of fix needs to be assessed before decision to uplift. See below:

On 5/7/13 12:03 AM, Christopher Lee wrote:

    Thanks Francis. 

    Sounds like you and Josh are going to review the latest patches from David tomorrow and provide an assessment on the quality.  

    I'm also going to get a build tomorrow and evaluate the latest changes and we can collectively make a call on if it's ready for uplift.

Comment 17

[Stephany Wilkes]

Assigning general FFOSUX needinfo to Francis, who is working on a collection of keyboard changes and improvements with Josh.

Comment 18

[Leo]

This issue is has been fixed in master Gaia.
But not uplifted in V1 train.
Will this be uplifted in V1 train?
Please comment.

Comment 19

[David Flanagan [:djf]]

Leo: I would like to uplift it, but it is not my decision.  Auto-correction is a new feature that has never been part of the plan for v1.1. The product and release managers will decide whether to uplift or not, I think.  See the discussion in the parent bug 797170.

Comment 20

[Tony Chung [:tchung]]

Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.

Comment 21

[David Flanagan [:djf]]

Uplifted to v1-train in bug 873934

Comment 22

[:CSchmoeckel]

Added Keyboard Suite Test Case #8501 - [Keyboard] Auto Correct's text prediction works correctly in the English Language & TC #8502 [Keyboard] Text prediction text entry in English keeps the capitalization entered by the user