Exiting customization is broken if the downloads button has been clicked
RESOLVED
FIXED
in Firefox 28
Status
()
People
(Reporter: mconley, Assigned: mconley)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
1.93 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
We're firing the CustomizationEnd event before we're done unwrapping all of the toolbaritems. The downloads button does some fancy sleight-of-hand with the downloads button and placeholder, and it expects the items to no longer be wrapped. I think this is consistent with how customization has always worked, so I figure we might as well just move the event to fire after unwrapping is done.
|
(Assignee) | |
Comment 1•6 years ago
|
||
Created attachment 735978 [details] [diff] [review] Patch v1
Attachment #735978 -
Flags: review?(jaws)
|
||
Updated•6 years ago
|
||
Attachment #735978 -
Flags: review?(jaws) → review+
|
|
(Assignee) | |
Comment 2•6 years ago
|
||
Thanks, landed in jamun as https://hg.mozilla.org/projects/jamun/rev/7d51bea19db4
Whiteboard: [fixed in jamun]
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
Landed on UX as https://hg.mozilla.org/projects/ux/rev/7d51bea19db4
Whiteboard: [fixed in jamun] → [fixed in jamun][fixed in ux]
|
|
||
Updated•5 years ago
|
||
Status: NEW → ASSIGNED
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4080b39a1a66
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed in ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•