Closed
Bug 860487
Opened 11 years ago
Closed 11 years ago
Exiting customization is broken if the downloads button has been clicked
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
1.93 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
We're firing the CustomizationEnd event before we're done unwrapping all of the toolbaritems. The downloads button does some fancy sleight-of-hand with the downloads button and placeholder, and it expects the items to no longer be wrapped. I think this is consistent with how customization has always worked, so I figure we might as well just move the event to fire after unwrapping is done.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #735978 -
Flags: review?(jaws)
Updated•11 years ago
|
Attachment #735978 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Thanks, landed in jamun as https://hg.mozilla.org/projects/jamun/rev/7d51bea19db4
Whiteboard: [fixed in jamun]
Assignee | ||
Comment 3•11 years ago
|
||
Landed on UX as https://hg.mozilla.org/projects/ux/rev/7d51bea19db4
Whiteboard: [fixed in jamun] → [fixed in jamun][fixed in ux]
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4080b39a1a66
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed in ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•