860530 - [Email] Quote reply header "{name} wrote" broken by translation of template argument {name} in some locales

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Leo]

1. Title : {name} wrote: text in reply body is not writing Name value in languages except English
2. Precondition : Email should be working, and phone language is other than english
3. Tester's Action : Email Inbox - Open a message - Click on Reply Button
4. Detailed Symptom (ENG.) :Reply body text not displaying value for {name} field.
5. Expected : Instead of {name} email name of the user should be displayed in other languages also.
6.Reproducibility: Y
1)Frequency Rate : 100%
7. User Impact: It is good to distinguish the previous user written message while replying to a message.
8.Gaia Revision:

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This appears to have been mis-localized in certain languages:  For example, in
https://hg.mozilla.org/releases/gaia-l10n/v1_0_1/es/file/43d4f4410981/apps/email/email.properties we incorrectly have:
reply-quoting-wrote={nombre} escribió

Whereas in https://hg.mozilla.org/releases/gaia-l10n/v1_0_1/pt-BR/file/be13ac7e0964/apps/email/email.properties we correctly have:
reply-quoting-wrote={name} escreveu

While I'm a little surprised that localizers would translate the template argument, we definitely did not have an l10n comment.

We could work-around the problem by just using a regex that transforms any {} pairing in this case, but I am concerned that it would be confusing down the road for localizers since there are cases where the template string does in fact matter a lot.  So I would suggest someone does a pass on the existing localizations to fix the incorrect ones.  And we can add l10n notes to en-US to help avoid this type of thing in the future.

Comment 2

[Dylan Oliver [:doliver]]

This issue was identified as a Leo QE1 blocker. Nominating for leo?

Comment 3

[Alex Keybl [:akeybl]]

Stas - this sounds like something we need to fix in the localization. Can you reassign?

I suspect this will end up being tef+

Comment 4

[Fabien Cazenave [:kaze]]

Attachment: proposed patch

add a “LOCALIZATION NOTE” to the email.en-US.properties file

Comment 5

[Fabien Cazenave [:kaze]]

Attachment: l10n fix

Patch for the Spanish locale in the l10n repository.
This should be pushed to the v1_0_1 repo, too.

I’ve checked all other locales for the v1_0_1 target, and the Spanish one is the only one that is affected.

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 738955 [details] [diff] [review]
proposed patch

Review of attachment 738955 [details] [diff] [review]:
-----------------------------------------------------------------

Kazé or Andrew:  can you also post a short reminder about variables in {} to dev-l10n?

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 738956 [details] [diff] [review]
l10n fix

Review of attachment 738956 [details] [diff] [review]:
-----------------------------------------------------------------

While this is technically correct (thanks, Kazé), let's not land anything in the [es] repository without looping the Spanish community in.  AFAIK, their workflow is based on Transifex, and I'm not sure how well this fix would import there.  Flagging willyaranda for review.   Willy, can you make sure this fix makes it to Spanish on v1_0_1 on Mercurial?

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Catched. Thanks, this was translated 6 months ago, wow!

Pushed, http://hg.mozilla.org/releases/gaia-l10n/v1_0_1/es/rev/c33a038da507

Comment 9

[Fabien Cazenave [:kaze]]

(In reply to Staś Małolepszy :stasfrom comment #6)
> Kazé or Andrew:  can you also post a short reminder about variables in {} to
> dev-l10n?

In this case it’s not a “standard” l10n {{variable}} — it’s an Email-specific template {variable}. That’s why I proposed this “LOCALIZATION NOTEl” on gaia-master.

Comment 10

[Fabien Cazenave [:kaze]]

master:
https://github.com/mozilla-b2g/gaia/commit/c9b550dae8a5ce6815466a94d1cbea89dab199fd

v1-train:
https://github.com/mozilla-b2g/gaia/commit/1780ef9c3b5bfe6d7f6f27389a8ef2d425bccc16

v1.0.1:
https://github.com/mozilla-b2g/gaia/commit/9b483e6903c6487400ae9bc3560daf39d45c6796

Comment 11

[Mila Davydova]

This issue appears to be fixed on v1.0.1 
Inari Build ID: 20130502070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/5c1d67e0c242
Gaia: 11477c127ae9be5051e4cfbcbf3da1d4150f9967
Version 18.0
{name} wrote: text in reply body is translated to the selected on the device language. Tested on both languages: Portuguese and Spanish

However, the issue reproduces on v1.1  when language is set to Spanish
Leo device build 20130502070205
Kernel Date: Apr 25
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/499c3627e89a
Gaia: 495c46489eb256be598a19ea54d7837ce4fc385b
Version 18.0
{name} wrote: text in reply body remains in English, when device is set to Spanish language.